Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark as single window app #4194

Closed
wants to merge 2 commits into from
Closed

Mark as single window app #4194

wants to merge 2 commits into from

Conversation

nicolasfella
Copy link
Contributor

There can only be one instace of the client running

Mark it as such in the .desktop file

This allows desktop environments to adjust their UI accordingly

Signed-off-by: Nicolas Fella [email protected]

mgallien
mgallien approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@mgallien
Copy link
Collaborator

@nicolasfella could you please rebase your PR on latest master such that we can merge it ?

@mgallien
Copy link
Collaborator

@nicolasfella can you have a look at the AppImage build error ?
looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view 😄 )

@nicolasfella
Copy link
Contributor Author

@nicolasfella can you have a look at the AppImage build error ? looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view smile )

SingleMainWindow is a very recent addition to the desktop file spec. It looks like the appimage tooling isn't up to date and doesn't account for version 1.5 of the spec

@mgallien
Copy link
Collaborator

mgallien commented Feb 3, 2022

@nicolasfella can you have a look at the AppImage build error ? looks like the new desktop file entry is supposedly not compliant (at least from this parser point of view smile )

SingleMainWindow is a very recent addition to the desktop file spec. It looks like the appimage tooling isn't up to date and doesn't account for version 1.5 of the spec

will have a look at updating the AppImage tooling

@camilasan camilasan self-assigned this Feb 7, 2022
@allexzander allexzander mentioned this pull request Feb 8, 2022
Closed
@camilasan
Copy link
Member

/rebase

@asensi asensi mentioned this pull request Jun 5, 2022
Merged
kdesysadmin pushed a commit to KDE/amarok that referenced this pull request Jun 5, 2022
@asensi
Mark Amarok as a single main window program
b0f5d2a 
As it happens with other programs (nextcloud/desktop#4194 ,
https://invent.kde.org/pim/knotes/-/commit/70e81d7286c83ff28deadb2f2b80e67b463d1db7 ,
qbittorrent/qBittorrent#15996 ,
https://nicolasfella.de/posts/taskbar-single-app ,
https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/53):

There can only be one instance of the program running. Mark it as such in
the .desktop file. This allows desktop environments to adjust their UI
accordingly.
kdesysadmin pushed a commit to KDE/ktorrent that referenced this pull request Jun 5, 2022
@asensi
Mark KTorrent as a single main window program
95ec8be 
As it happens with other programs (nextcloud/desktop#4194 ,
https://invent.kde.org/pim/knotes/-/commit/70e81d7286c83ff28deadb2f2b80e67b463d1db7 ,
qbittorrent/qBittorrent#15996 ,
https://nicolasfella.de/posts/taskbar-single-app ,
https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/53):

There can only be one instance of the program running. Mark it as such in
the .desktop file. This allows desktop environments to adjust their UI
accordingly.
kdesysadmin pushed a commit to KDE/partitionmanager that referenced this pull request Jun 5, 2022
@asensi
Mark KDE Partition Manager as a single main window program
e41ffaa 
As it happens with other programs (nextcloud/desktop#4194 ,
https://invent.kde.org/pim/knotes/-/commit/70e81d7286c83ff28deadb2f2b80e67b463d1db7 ,
qbittorrent/qBittorrent#15996 ,
https://nicolasfella.de/posts/taskbar-single-app ,
https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/53):

There can only be one instance of the program running. Mark it as such in
the .desktop file. This allows desktop environments to adjust their UI
accordingly.
kdesysadmin pushed a commit to KDE/partitionmanager that referenced this pull request Jun 5, 2022
@asensi @stikonas
Mark KDE Partition Manager as a single main window program
abea317 
As it happens with other programs (nextcloud/desktop#4194 ,
https://invent.kde.org/pim/knotes/-/commit/70e81d7286c83ff28deadb2f2b80e67b463d1db7 ,
qbittorrent/qBittorrent#15996 ,
https://nicolasfella.de/posts/taskbar-single-app ,
https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/53):

There can only be one instance of the program running. Mark it as such in
the .desktop file. This allows desktop environments to adjust their UI
accordingly.
@asensi
Copy link

asensi commented Jul 19, 2022

Hello, I would suggest using SingleMainWindow=true instead of SingleMainWindow=True. That change avoids some errors like:

I try to package the latest unstable ktorrent based on this commit, but there is a desktop-file-validate error from the check stage:

$ desktop-file-validate org.kde.ktorrent.desktop
org.kde.ktorrent.desktop: error: value "True" for boolean key "SingleMainWindow" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
-- https://invent.kde.org/network/ktorrent/-/commit/95ec8bef250748f67b6cbb06abb944118b5aa9ac#note_488877

@nicolasfella @mgallien
Mark as single window app
46e3179 
There can only be one instace of the client running

Mark it as such in the .desktop file

This allows desktop environments to adjust their UI accordingly

Signed-off-by: Nicolas Fella <[email protected]>
@codecov
Copy link

codecov bot commented Sep 17, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.24%. Comparing base (8a73a9a) to head (326a1f6).
Report is 2387 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
- Coverage   60.26%   60.24%   -0.02%     
==========================================
  Files         145      145              
  Lines       18868    18868              
==========================================
- Hits        11370    11367       -3     
- Misses       7498     7501       +3

see 1 file with indirect coverage changes

@mgallien
Copy link
Collaborator

closing in favor of #7124

@Rello Rello closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@camilasan camilasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolasfella @mgallien @camilasan @asensi @allexzander @claucambra @Rello