Fix Desktop file error #7054
Fix Desktop file error #7054
Conversation
Validating the generated com.nextcloud.desktopclient.nextcloud.desktop file with desktop-file-validate shows the error error: file contains group "org.freedesktop.CloudProviders", but groups extending the format should start with "X-" This commit fixes the error and the generated desktop file is following the freedesktop.org Desktop Entry Specification. Fixes nextcloud#7053 Signed-off-by: apt-ghetto <[email protected]>
|
I am not sure if this change is breaking stuff. A Please feel free to improve or reject this PR. |
There was a problem hiding this comment.
GNOME docs would disagree with this change: https://world.pages.gitlab.gnome.org/libcloudproviders/implementing-cp.html
Thank your for this hint. I will dig deeper. |
|
I opened https://gitlab.gnome.org/World/libcloudproviders/-/issues/25 because the name is used in the libcloudproviders source code. |
|
The validation fails because of a bug in desktop-file-utils itself and should be fixed with https://gitlab.freedesktop.org/xdg/desktop-file-utils/-/commit/0edb077899d696601d285c9891c8be61b8903634 but is not released yet. The error will disappear in "the future". I guess I can click "Close with comment" and close this PR? Or what is the recommended Github way to handle this? |
Validating the generated com.nextcloud.desktopclient.nextcloud.desktop file with desktop-file-validate shows the error
error: file contains group "org.freedesktop.CloudProviders", but
groups extending the format should start with "X-"
This commit fixes the error and the generated desktop file is following the freedesktop.org Desktop Entry Specification.
Fixes #7053