remove some frames in group of settings to simplify layouts

[mgallien]

on Windows
Windows native widget style
before

[mgallien]

regarding design feedback, I am unsure who I should put as reviewers
I am now testing on Linux KDE Plasma desktop
will ask Camila or Claudio for macOS feedback
I am waiting for feedback before making changes in all settings pages (or not)

[jancborchardt]

Nice, looks much more modern.
A detail, but why is there so much additional whitespace below the options in each of the sections, can that be removed?

(I don't mean the big whitespace between the sections and the bottom, I know that's there to keep the height consistent. :)

[mgallien]

the label with the desktop client name and release is now left aligned as it should have been
so please ignore this in the screenshots

[claucambra]

On macOS the result is less positive

After changes:

Before changes:

[mgallien]

updated windows screenshots

[jancborchardt]

It does look different – and it does look a few steps closer to more native when checking @AndyScherzinger’s screenshots.

On Mac OS it also needs to keep staying natively, or at least not move back, as @claucambra mentioned.

There often seem to be some alignment issues like different amount of whitespace between checkbox lines (first 3 in General → Advanced vs the other ones), and also the aforementioned whitespace inside the bottom of the proxy and bandwidth boxes.

[AndyScherzinger]

TO add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned

[jancborchardt]

To add to Jan's comment, centered headlines are also uncommon on Windows' settings UIs. Things are generally start aligned

Totally agree, also generally design-wise they look a bit lost when centered, best to keep them left-aligned in any case.

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-7051-7e8e6ac48aa1d2deb5bffc17186c5986bc40f8b6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[mgallien]

too much issues in this PR
not sure what to do
maybe close and start again from scratch

[jancborchardt]

@mgallien yes, let’s always do things step by step. Is there any follow-up to this already?