-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/office files lock newly created. Plus refactoring. #6613
Conversation
65823eb
to
a133669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
a133669
to
f57f847
Compare
No Clang-Tidy warnings found so I assume my comments were addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgallien Should be fixed now, kindly test with new build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works
47fe39a
to
686e6d8
Compare
Signed-off-by: alex-z <[email protected]>
686e6d8
to
dbde9e3
Compare
AppImage file: nextcloud-PR-6613-dbde9e3a2b3efab1c0902c0516207e9d21489f76-x86_64.AppImage |
/backport to stable-3.13 |
/backport to stable-3.12 |
The backport to # Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12
# Create the new backport branch
git checkout -b backport/6613/stable-3.12
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick dbde9e3a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6613/stable-3.12 Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout: Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
No description provided.