Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when clicking on import legacy account dialog 'Skip' button. #6184

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix crash when clicking on import legacy account dialog 'Skip' button. #6184

merged 1 commit into from
Nov 7, 2023

Conversation

camilasan
Copy link
Member

With Qt::WA_DeleteOnClose the message box was being deleted twice.

@camilasan
Copy link
Member Author

/backport to stable-3.10

@camilasan camilasan force-pushed the bugfix/messagebox-crash branch from fa668a0 to 3525260 Compare October 30, 2023 17:01
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #6184 (1158711) into master (406bad8) will increase coverage by 0.16%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

❗ Current head 1158711 differs from pull request most recent head 44e8e4b. Consider uploading reports for the commit 44e8e4b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6184      +/-   ##
==========================================
+ Coverage   60.56%   60.73%   +0.16%     
==========================================
  Files         145      145              
  Lines       18846    18846              
==========================================
+ Hits        11414    11446      +32     
+ Misses       7432     7400      -32

see 8 files with indirect coverage changes

@claucambra claucambra force-pushed the bugfix/messagebox-crash branch from 3525260 to 1158711 Compare November 2, 2023 05:54
Fix crash when clicking on import legacy account dialog 'Skip' button.
44e8e4b 
- mac OS only: With Qt::WA_DeleteOnClose the dialog was being deleted twice.

Signed-off-by: Camila <[email protected]>
@camilasan camilasan force-pushed the bugfix/messagebox-crash branch from 1158711 to 44e8e4b Compare November 7, 2023 17:33
@camilasan camilasan enabled auto-merge November 7, 2023 17:34
@camilasan camilasan changed the title Fix crash on mac OS. Fix crash when clicking on import legacy account dialog 'Skip' button. Nov 7, 2023
@camilasan camilasan disabled auto-merge November 7, 2023 17:46
@camilasan camilasan merged commit 78b5928 into master Nov 7, 2023
9 checks passed
@camilasan camilasan deleted the bugfix/messagebox-crash branch November 7, 2023 17:46
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 7, 2023
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6184-44e8e4b2e96b374b6c541cb29e601fbc862d74d1-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@allexzander allexzander allexzander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@camilasan @nextcloud-desktop-bot @allexzander @claucambra @mgallien