Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build Finder Sync Extension when File Provider Module is enabled #6183

Closed
claucambra opened this issue Oct 30, 2023 · 2 comments
Closed
Assignees
Labels
enhancement enhancement of a already implemented feature/code feature: 💽 virtual filesystem os: 🍎 macOS

Comments

@claucambra
Copy link
Collaborator

How to use GitHub

  • Please use the 👍 reaction to show that you want to have the same feature implemented.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature description

Since the two modules are incompatible, it doesn't make sense to include them both

File provider-based builds should omit the finder sync extension

@claucambra claucambra added the enhancement enhancement of a already implemented feature/code label Oct 30, 2023
@claucambra claucambra self-assigned this Oct 30, 2023
@marcotrevisan
Copy link

So I guess a future Release will contain (at least in theory) two distinct .dmg files to choose from, am I correct?
One for the FileProvider enabled client and one for the "legacy" version?
Thanks!

@claucambra
Copy link
Collaborator Author

So I guess a future Release will contain (at least in theory) two distinct .dmg files to choose from, am I correct? One for the FileProvider enabled client and one for the "legacy" version? Thanks!

That's correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Development

No branches or pull requests

2 participants