Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash. Remove unnecessary dependency injection causing crash. #6178

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #6178 (dd178f0) into master (44e8e4b) will increase coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6178      +/-   ##
==========================================
+ Coverage   60.73%   60.77%   +0.04%     
==========================================
  Files         145      145              
  Lines       18846    18836      -10     
==========================================
+ Hits        11446    11448       +2     
+ Misses       7400     7388      -12     
Files Coverage Δ
src/common/checksumcalculator.cpp 85.36% <100.00%> (-1.22%) ⬇️
src/common/checksumcalculator.h 100.00% <ø> (ø)
src/common/checksums.cpp 79.23% <100.00%> (+5.65%) ⬆️
src/common/checksums.h 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@mgallien mgallien enabled auto-merge November 9, 2023 12:24
@mgallien mgallien force-pushed the bugfix/checksum-calculator-crash branch from bb9dbd3 to dd178f0 Compare November 9, 2023 12:24
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6178-dd178f032c704b01a33ed1e22abccbf337730332-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit b643773 into master Nov 9, 2023
13 checks passed
@mgallien mgallien deleted the bugfix/checksum-calculator-crash branch November 9, 2023 14:16
@allexzander
Copy link
Contributor Author

/backport to stable-3.10

@allexzander
Copy link
Contributor Author

/backport to stable-3.11

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants