-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/restore folders recursively #6134
Conversation
/backport to stable-3.10 |
ea85c78
to
f2d7e29
Compare
Signed-off-by: Matthieu Gallien <[email protected]>
we should not try to restore files/folders no longer synced because of selective sync when detecting a data fingerprint change in case the user deselect a folder from selective sync list, we would do a local delete in case the client is also detecting a change of data fingerprint (or is stuck in restore mode) then instead of applying the new set of selected folders to sync, it would upload unselected files/folders Signed-off-by: Matthieu Gallien <[email protected]>
in case sync would complete after a data fingerprint change, we should tolerate some errors a file being blacklisted for whatever reason should not block the propagation of data fingerprint Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
f2d7e29
to
242135d
Compare
AppImage file: nextcloud-PR-6134-242135d9d92ea0f71a2940efc585177fc8a8766e-x86_64.AppImage |
SonarCloud Quality Gate failed. 0 Bugs 75.0% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6134 +/- ##
==========================================
+ Coverage 60.47% 60.56% +0.08%
==========================================
Files 145 145
Lines 18814 18814
==========================================
+ Hits 11378 11394 +16
+ Misses 7436 7420 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any changes to calls/connections to slotPropagationFinished
, I am guessing these do not need to be changed to use the enum?
No description provided.