Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report client status #6124

Closed
tobiasKaminsky opened this issue Oct 9, 2023 · 2 comments · Fixed by #6247
Closed

Report client status #6124

tobiasKaminsky opened this issue Oct 9, 2023 · 2 comments · Fixed by #6247
Assignees
Labels
enhancement enhancement of a already implemented feature/code

Comments

@tobiasKaminsky
Copy link
Member

See nextcloud/files-clients#45

@tobiasKaminsky tobiasKaminsky added the enhancement enhancement of a already implemented feature/code label Oct 9, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 🤖 🍏 Clients team Oct 9, 2023
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (max 2 entries / member) in 🤖 🍏 Clients team Oct 9, 2023
@allexzander
Copy link
Contributor

My ideas so far:

  • Send sync status failure along with current log file in compressed form, mark current log file dirty in the local database, so it gets transferred to the server when complete (closed and zipped by logger)
  • Every sent error can be recorded to the local database along with the file path and time stamp + error type, to avoid sending the same error and spamming the server
  • Alternatively, each error is sent to the server allowing sending duplicates, but letting server accumulate such duplicates and display accordingly
  • When sending sync errors, include required details explaining the reason for failure: server error with code and message, local problem with write permissions or disk space limit, other network errors related to bad connection or packet loss (not sure how possible this is now as we do not have network diagnostics feature)
  • Differentiate errors based on specific scenarios: VFS hydration, E2E folder encryption or decryption, normal file syncing (uploads or downloads)
  • Send errors for other features (sharing, local file editing, file lock and unlock feature)
  • E2EE errors must be sent in such a way that encrypted files and folder names are not decrypted in such error reports (mangled names are kept)

@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (max 2 entries / member) to 🏗️ In progress in 🤖 🍏 Clients team Nov 2, 2023
@tobiasKaminsky
Copy link
Member Author

  • send data once a day
  • check for capability on server
  • do not send any data if there is nothing to report
  • data format: error_code: count, earliest occurence, e.g: VIRUS_DETECTED: 1, 1698931253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants