Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use material icon for folders. #6114

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Use material icon for folders. #6114

merged 1 commit into from
Oct 6, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Oct 5, 2023 •
edited
Loading

image

@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #6114 (37b22c0) into master (623fe40) will decrease coverage by 0.06%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6114      +/-   ##
==========================================
- Coverage   60.53%   60.48%   -0.06%     
==========================================
  Files         145      145              
  Lines       18805    18805              
==========================================
- Hits        11384    11374      -10     
- Misses       7421     7431      +10

see 6 files with indirect coverage changes

@allexzander allexzander force-pushed the feature/use-material-icons branch from a248a10 to 4101abf Compare October 5, 2023 10:14
mgallien
mgallien requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add before and after screenshots ?

src/gui/tray/NCIconWithBackgroundImage.qml Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien October 5, 2023 16:38
@mgallien mgallien force-pushed the feature/use-material-icons branch from ccaad27 to cedcc0c Compare October 6, 2023 08:01
@mgallien mgallien enabled auto-merge October 6, 2023 08:01
@allexzander allexzander force-pushed the feature/use-material-icons branch from cedcc0c to 37b22c0 Compare October 6, 2023 08:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6114-37b22c021c10b77d4894bcc8410c92a1a3fada58-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander disabled auto-merge October 6, 2023 09:10
@allexzander allexzander merged commit 9289883 into master Oct 6, 2023
12 of 13 checks passed
@allexzander allexzander deleted the feature/use-material-icons branch October 6, 2023 09:10
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@allexzander @nextcloud-desktop-bot @mgallien