[stable-3.10] Prevent empty password being passed into share creation #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already generate a new password when the share password dialog is created, so there is really no need to clear the field when it closes. This prevents the field being cleared before the password is sent into the C++ code, leading to no password actually being sent to the server Signed-off-by: Claudio Cambra <[email protected]>
This was referenced Sep 29, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## stable-3.10 #6107 +/- ##
===============================================
- Coverage 60.62% 60.33% -0.30%
===============================================
Files 145 145
Lines 18793 18793
===============================================
- Hits 11394 11338 -56
- Misses 7399 7455 +56 |
|
Kudos, SonarCloud Quality Gate passed!
|
claucambra
approved these changes
Oct 2, 2023
claucambra
changed the title
|
AppImage file: nextcloud-PR-6107-608452b3ecc717c5d7409660e881a3be536954ac-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already generate a new password when the share password dialog is created, so there is really no need to clear the field when it closes. This prevents the field being cleared before the password is sent into the C++ code, leading to no password actually being sent to the server