Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent empty password being passed into share creation #6100

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Prevent empty password being passed into share creation #6100

merged 1 commit into from
Oct 4, 2023

Conversation

claucambra
Copy link
Collaborator

We already generate a new password when the share password dialog is created, so there is really no need to clear the field when it closes. This prevents the field being cleared before the password is sent into the C++ code, leading to no password actually being sent to the server

Closes #6081

@claucambra claucambra self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #6100 (f3ea30c) into master (c1e8755) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head f3ea30c differs from pull request most recent head 8fbd6ef. Consider uploading reports for the commit 8fbd6ef to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6100   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files         145      145           
  Lines       18800    18800           
=======================================
  Hits        11343    11343           
  Misses       7457     7457

@claucambra claucambra force-pushed the bugfix/share-password-dialog branch from e224665 to f3ea30c Compare September 28, 2023 05:51
@claucambra claucambra mentioned this pull request Sep 29, 2023
Closed
8 tasks
@nextcloud nextcloud deleted a comment from claucambra Sep 29, 2023
@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Sep 29, 2023 •
edited
Loading

Manual backport: #6107
So that we can use it with brander.

@mgallien mgallien force-pushed the bugfix/share-password-dialog branch from f3ea30c to 7a839b6 Compare October 3, 2023 07:37
@mgallien mgallien enabled auto-merge October 3, 2023 07:37
@claucambra
Prevent empty password being passed into share creation
8fbd6ef 
We already generate a new password when the share password dialog is
created, so there is really no need to clear the field when it closes.
This prevents the field being cleared before the password is sent into
the C++ code, leading to no password actually being sent to the server

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra force-pushed the bugfix/share-password-dialog branch from 7a839b6 to 8fbd6ef Compare October 4, 2023 10:58
@claucambra claucambra disabled auto-merge October 4, 2023 11:00
@claucambra claucambra merged commit 5046b8c into master Oct 4, 2023
8 of 9 checks passed
@claucambra claucambra deleted the bugfix/share-password-dialog branch October 4, 2023 11:00
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6100-8fbd6ef7901f13affd2ef18214f72b79591c60f7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
backport-request
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Windows 11 Client ver 3.10.0 Error file sharing with password
4 participants
@claucambra @tobiasKaminsky @nextcloud-desktop-bot @mgallien