Bugfix/legacy migration

[camilasan]

• cleans up a bit the Application constructor
• delays the display of the dialog notifying the user that the migration worked

TODO

• test on Mac OS
• test on Windows
• get feedback from @nextcloud/designers

dialog 1:

dialog 2:

dialog when nothing was imported:

[codecov]

Codecov Report

Merging #6072 (d517cbf) into master (bb09bc6) will decrease coverage by 0.42%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6072      +/-   ##
==========================================
- Coverage   60.33%   59.92%   -0.42%     
==========================================
  Files         145      145              
  Lines       18800    18800              
==========================================
- Hits        11343    11265      -78     
- Misses       7457     7535      +78     

see 7 files with indirect coverage changes

[nimishavijay]

Looks good generally :) some small points:

• show the configuration details in the confirmation dialog
  2 accounts and 4 folders were detected on a legacy desktop client. Should the accounts and folders be imported?
  • Note: use correct wording, for eg. 1 account was detected on a legacy desktop client. Should the account be imported?
• if the number of accounts and folders is 0 (for both) then don't show the dialog and directly show the setup wizard
• change wording of buttons to "Import" and "Skip"

(decided to not show the detailed results of the import as it might be too long, if there is a way to show and hide the results then we could include it, but otherwise a simple confirmation is enough :) )

[privatemaker]

if there is a way to show and hide the results then we could include it

Perhaps the details could be put in an triangular collapsible text box?

@camilasan also brought up idea of showing user names- I like this idea. Something simple like:

Imported 2 accounts and 4 folders.

- Private Maker
- Disco Dancing Club

[camilasan]

@privatemaker @nimishavijay @jancborchardt what do you think?

1 account:

2 or more accounts:

[nimishavijay]

Looks good! 2 small changes that was missed with the previous feedback:

• "1" instead of "one" to maintain consistency when referring to different numbers
• switch the position of "Import" and "Skip" buttons so the primary action is always in the bottom right

After that, it is super nice! :)

[camilasan]

• switch the position of "Import" and "Skip" buttons so the primary action is always in the bottom right

Sadly I can't:
"The ButtonRole is used by QMessageBox to determine the ordering of the buttons on screen (which varies according to the platform)."

[claucambra]

Code-wise looks good

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6072-d517cbfd687c70fa2123fad54eaa63d85993b52d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[mgallien]

/backport to stable-3.10