Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic locking for Office files #5893

Closed
tobiasKaminsky opened this issue Jul 17, 2023 · 13 comments · Fixed by #5986
Closed

Allow automatic locking for Office files #5893

tobiasKaminsky opened this issue Jul 17, 2023 · 13 comments · Fixed by #5986
Assignees
Labels
enhancement enhancement of a already implemented feature/code

Comments

@tobiasKaminsky
Copy link
Member

No description provided.

@tobiasKaminsky tobiasKaminsky added the enhancement enhancement of a already implemented feature/code label Jul 17, 2023
@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Jul 17, 2023
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (max 2 entries / member) in 🤖 🍏 Clients team Jul 20, 2023
@jospoortvliet
Copy link
Member

jospoortvliet commented Aug 3, 2023

I thought this feature was already there? In the announcement we wrote:
"The Desktop Client introduces automated file locking, where it will detect when you locally open a file and locks it on the server to avoid editing conflicts. When you are closing your application, the file is unlocked again."

or is this something different?

@jospoortvliet
Copy link
Member

so I think that text is wrong - just checking, I see files get locked when edited online (made read-only locally) but the other way around, editing locally does not lock online. Bit of lsof magic needed I guess 🙈

@alexanderdd
Copy link

Not sure if this should be discussed here, in the pull request #5986 or in a new issue? @tobiasKaminsky

I tested this with three other people and it did not work 😐

Setup:

  • Server: Nextcloud 27.1.2
  • Collabora CODE 23.05.5.20231013
  • Person A: Linux Mint 20.3 with Appimage client 3.10, Libreoffice 6.4.7.2
  • Person B: Windows 10, client 3.10 (virtual files enabled and later disabled – neither worked), MS Office 2309
  • Person C: macOS ventura 13.4.1, Nextcloud client 3.10, MS Office 16.78

Scenarios:

  • Person A opens .odt locally with Libreoffice, then opens the same file in web – no warning
  • Person A opens .odt in web, then opens the same file locally with Libreoffice – no warning
  • Person B opens .docx locally with MS Office, Person C opens the same file locally with MS Office – no warning
  • Person B opens .docx locally with MS Office, Person C opens the same file in web – no warning
  • Person B opens .docx in web, Person C opens the same file locally with MS Office – no warning

Conclusion:

I conclude that in our setup, none of the file locks worked, neiter for Libreoffice nor for MS Office. We saw the lockfiles for MS Office (~$ in the beginning) being synced both in web and locally, but it did not lead to a lock/warning.

In the pull request #5986 people said that there are problems with ubuntu (so probably also with Linux Mint). But the other scenarios should have worked, right?

I can provide more details if necessary.

@jabo59
Copy link

jabo59 commented Mar 9, 2024

I have the same problem and the way nextcloud handles this creates a lot of confusion among my users.

@AT-StephenDetomasi
Copy link

Just wanted to chime in that I'm also seeing inconsistent behaviour here. Anyone tried the latest versions to see if that improves anything?

@jabo59
Copy link

jabo59 commented Mar 14, 2024

My problem remains. I‘m using v28.0.3 with app „temporary file locks“ activated.

@AT-StephenDetomasi
Copy link

Problem appears to be ongoing. It's problematic to the point where we are looking at switching away from NextCloud. Has anyone found a suitable workaround?

@jabo59
Copy link

jabo59 commented Mar 28, 2024

No. I‘m currently trying with file locking disabled. I plan also to check this with nextcloud v29. But this will take time.

@AT-StephenDetomasi
Copy link

NextCloud 29 RC is available now. I don't see any major changes though so I'm not going to hold my breath.

@thprv
Copy link

thprv commented Apr 30, 2024

Not working on NC 27.1.5 and client 3.13.0 on macOS either.

@Jerome-Herbinet
Copy link
Member

Not working on NC 27.1.5 and client 3.13.0 on macOS either.

Works for me with the following environment @thprv :

  • Nextcloud Server 27.1.9 (very last minor release)
  • Nextcloud Desktop Sync 3.13.0 (very last minor release)
  • Nextcloud Temporary Files Lock 27.0.6 (very last minor release)

Files are opened with LibreOffice.

Tested with Ubuntu 22.04 LTS, then with Windows 11. Not tested with macOS.

@AT-StephenDetomasi
Copy link

Interesting to hear people do have it working. We are in the process of migrating away from Nextcloud over this issue, would love to be able to cancel the project if someone can get this solved.

@thprv
Copy link

thprv commented Sep 10, 2024

After our hoster made some updates, it is working for me now (after conducting a short experiment, more to follow).

Nextcloud: 28.0.7.5
Nextcloud-Client: 3.13.3
Temporary Files lock: 28.0.6

Will have to check if poll/sync frequency defaults for the client work out in our office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

10 participants