Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5.1] client marks ignored files as sync conflict #566

Closed
Germano0 opened this issue Aug 18, 2018 · 61 comments
Closed

[2.5.1] client marks ignored files as sync conflict #566

Germano0 opened this issue Aug 18, 2018 · 61 comments
Assignees
Labels
Milestone

Comments

@Germano0
Copy link

Germano0 commented Aug 18, 2018

I installed 2.5.0 over a previous 2.3.3 version. With the old client version, the folders synchronization was okay, with 2.5.0 instead it is stuck on a specific folder (let's call it "LLL") marked with "there are unresolved conflicts, click for details". I click and I simply get a list of files being ignored because they are usually temp or backup files, like .foo.bar, foo.bar~, ~foo.bar.
So there are no conflicts, only files being ignored.

Note that as soon the "LLL" folder start the sync, I get the alert message and the sync stops

@camilasan camilasan self-assigned this Aug 19, 2018
@zippytiff
Copy link

Hi,

I have just tried my 1st 2.5 build (Nextcloud-2.5.0.61459-daily-20181011)

I can see the Files ignored by Patterns, has been dramatically reduced, which is good.

However I also see this issue, except that despite hidden files being syncd is on, I get:

File is listed on the ignore list for ~$sampleexcel.xls (yes the file is closed)

Also im getting error on various files for Conflicts, where Server version downloaded, local copy renamed and not uploaded

finally .iTunes Preferences.plist thowing an error

In the end I just want everything to sync, unless either chosen by the server (which that feature was in this version eg settings controlled by the server !) or by me.

Me just seeing a Green tick as per 2.3.3

I will revert back to that version for now

Thanks ZT

@zippytiff
Copy link

Solution was to not use the client gui, but to edit the file in the new roaming (not local anymore) location

Guess this is a client bug....

ZT

@heidlma
Copy link

heidlma commented Oct 31, 2018

I am seeing the same issue. The 2.5 client gives me "unresolved conflicts", but when I click on the message ("Click for details"), nothing happens.

I am running on macOS HS, client version is 2.5.0rc1 (build 20181026)

After downgrade to 2.3.3 client, all seems to be ok again.

@augustseptember
Copy link

In the 2.5git (ubuntu18.04) i get the same "unresolved conflicts". If I click on it, it shows me a very long list of ignored files, which should not be ignored anymore due to the reduced ignore patterns.

@TP75
Copy link

TP75 commented Nov 15, 2018

Confirmed. The same issue with macOS 10.12 and NC Client Nextcloud-2.5.0.20181112.pkg i.e. Version 2.5.0daily (build 20181112) for all the users of our local NC 13.0.7 server.

One may consider the Nextcloud Client Manual section Conflicts to manually resolve the a.m. issue. However, I am unsure if the paragraph Uploading conflicts (experimental) might be useful for a workaround or would be misleading.

Please be aware there appears to be a more general documentation issue What is the current Client Manual? #839 One would expect the availability of a documentation for both the 2.3 and the 2.5 NC Client.

@Germano0 Germano0 changed the title [2.5.0b1] client marks ignored files as sync conflict [2.5.0] client marks ignored files as sync conflict Nov 15, 2018
@Germano0
Copy link
Author

I still experience the problem on 2.5.0 final.
I will not push nextcloud-client to Fedora / EPEL stable repository until this problem will be fixed

@wiserweb
Copy link

wiserweb commented Nov 16, 2018

Confirming that the issue described by OP is still occurring.
It occurs on Linux as well.
Confirming that MacOS and Linux client with 2.3.3 do not exhibit this bug.
I suppose this will have to be a new test-case that will be added to QA so to ensure that this functionality is properly tested before shipping a release as production ready.

@rullzer
Copy link
Member

rullzer commented Nov 19, 2018

Does anybody have log files or steps to reproduce this?
I tried it locally and it seems just to work no mater what I put in the ignore pattern

@augustseptember
Copy link

Trying to sync a file with ~ at the end of the filename the client logs say:

...[_csync_merge_algorithm_visitor INSTRUCTION_IGNORE client file: path/to/file/file_with_tilde~ ... [csync_ftw <= Closing walk for with read_from_db 0 [csync_update Update detection for remote replica took 74.093 seconds walking 31725 files [csync_memstat_check Memory: 2486580K total size, 873896K resident, 30828K shared [OCC::SyncEngine::slotDiscoveryJobFinished #### Discovery end #################################################### 91355 ms ... [OCC::PropagateItemJob::scheduleSelfOrChild Starting INSTRUCTION_IGNORE propagation of "path/to/file/file_with_tilde~" by OCC::PropagateIgnoreJob(0x55ddcab01f60) [OCC::PropagateItemJob::done Could not complete propagation of "path/to/file/file_with_tilde~" by OCC::PropagateIgnoreJob(0x55ddcab01f60) with status 6 and error: "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityWidget::slotItemCompleted Item "path/to/file/file_with_tilde~" retrieved resulted in "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityWidget::slotItemCompleted Item "path/to/file/file_with_tilde~" retrieved resulted in error "Die Datei ist in der Ignorierliste geführt." [OCC::ActivityListModel::addErrorToActivityList Error successfully added to the notification list: "Die Datei ist in der Ignorierliste geführt."

But in the ignore list is no entry for files with ~
ignorelist

@leighss
Copy link

leighss commented Nov 19, 2018

@augustseptember
My ignore files settings looked like that until I took @brianbgness advice from #851 and reset to defaults, then lots of other entries (including ~ones) appeared in the list

@augustseptember
Copy link

@leighss thanks for the advice but this doesn't change anything for me.

@rullzer
Copy link
Member

rullzer commented Nov 19, 2018

@augustseptember that is a different issue. But ~ files are ignored because they are temp files by definition.we probably can make that more clear

@leighss
Copy link

leighss commented Nov 19, 2018

That also didn't change anything for me, but I thought it may have helped in diagnosing problem

@augustseptember
Copy link

@rullzer yes there could be some fixed entries in the ignore list, which can't be deleted from that list. You would at least be informed that some patterns (~) or files (like .htacess) are generally not synced.

But why is there still the warning about conflicts in the client?

@rullzer
Copy link
Member

rullzer commented Nov 19, 2018

Note that .htaccess is blocked server side.

I do not know why the warning is there. That is why I need steps to reproduce as it doesn't happen for me. No matter what I add to the sync list. Only if create conflicts in files that are synced I see them but that is to be exepcted.

@rullzer
Copy link
Member

rullzer commented Nov 19, 2018

Ah ok at least I'm a step further. It indeed looks like the system exclude list is always read. I'm not sure how this snuck back in. I'll prepare a PR to fix that at least.

@augustseptember
Copy link

augustseptember commented Nov 19, 2018

hmm...
i just updated my nextcloud-client from 2.3.3 to 2.5 with your ppa for ubuntu 18.04. The yellow warnings was there from the beginning.

@leighss
Copy link

leighss commented Nov 19, 2018

Hopefully I am not muddying the waters as I do not understand the technicalities, but...

@rullzer mentioning .htaccess jogged my memory...

I did notice that amongst the many yellow ! warning logs about ignored files there were two red X server error logs and when I followed them in the file manager they were .htaccess files in my synced content.

I have three locations (I'll call them A, B & C) that I sync.
One .htaccess files is in B, and the other in C.
However, A & C give me a yellow ! error overall, not a red X.

A has started to give me a green tick again (I am not sure why, perhaps after resetting defaults?) and has no error relating to an .htaccess file

rullzer added a commit that referenced this issue Nov 19, 2018
For #566

Since we only showed the user exclude list (and some extra items) the
system exclude list was still used.

This copies over the system exclude list (if it isn't there).
If it fails we use the system one still.

However if you now remove items from your own list it will really be
gone.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer
Copy link
Member

rullzer commented Nov 19, 2018

I do not think this solves it but it should make hte list more clear: #860

@TrilceAC
Copy link

TrilceAC commented Nov 21, 2018

I'm having the same conflict issue described above. With the previous version on a Ubuntu 16.04 I had no issue. I've just update to 2.5.0git using the repository and now I have lots of "File is listed on the ignore list". In my case, I use Nextcloud to sync some python projects I'm working on. This is quite useful when changing from PC to laptop or going home. Sometimes the code is not in a state that I can commit, but I want to see and finish what I was working on on a different computer. To avoid silly or prejudicial syncs I added to the ignored files the following two patterns:

*.pyc
__pycache__/*

This has been working fine for me untill now. Since the update I see the yellow flag indicating that "There are unresolved conflicts. Click for details" When I click, all *.pyc files are mark as conflictive saying that "File is listed on the ignore list."

I hope I'm not doing something obviouly wrong and that this report helps to solve the issue.

@get2him
Copy link

get2him commented Nov 21, 2018

This has been working fine for me untill now. Since the update I see the yellow flag indicating that "There are unresolved conflicts. Click for details" When I click, all *.pyc files are mark as conflictive saying that "File is listed on the ignore list."

I hope I'm not doing something obviouly wrong and that this report helps to solve the issue.

I had the same problem with win client 2.5.0.
I've checked the option to sync hidden files in the Advanced Options -> Ignored Files Editor.
The issue resolved.

@TrilceAC
Copy link

I had the same problem with win client 2.5.0.
I've checked the option to sync hidden files in the Advanced Options -> Ignored Files Editor.
The issue resolved.

I think you resolved the issue because you are now sync hidden files. I already had this option marked but the isssue is there.

As mentioned here, I have just clicked on "Restore Defaults" and the list of ignored patters has significantly increased. Before clicking OK I have added the two extra patterns I mentioned above and I have clicked OK. After clicking, Nextcloud has performed a full check for changes. While it was performing it, it was happy with the sync, but just when it ended, the yellow flag and the unresolved conflicts have come back because of the .pyc files.

@leighss
Copy link

leighss commented Nov 21, 2018

@TrilceAC - exactly the same behaviour as happened with me
I had already:
Reset to defaults (list increased)
Selected sync hidden files

but still had the same behaviour

Then I took @mr-bolle's advice (from my forum post) and deleted all the _conflict files (I just searched for them using catfish).

This did not initially work, but a few more syncs latter I got the green ticks again :)
I also reset to defaults one more time after deleting the conflict files, but I don't know if this was part of the solution/ what triggered the green ticks once the _conflict files had been deleted.

The conflict files were from 09/09/2018, so they were already there and not giving this behaviour with client 2.3.3, this only started with 2.50

@rullzer
Copy link
Member

rullzer commented Nov 21, 2018

@leighss it makes sense it showsthere are unresolved conflicts if you still have conflict files.

Of course clicking on the message should show you which files.

I guess there might be an issue with conflict files and ignored file detection. I'll try to reproduce that.

@David-Lor
Copy link

Still present under Ubuntu (2.5.2git)

@paulsommer
Copy link

Same here. The activity list is flooded with yellow exclamation marks.rendering it useless for finding real conflicts.

@ppochon
Copy link

ppochon commented Jul 7, 2019

Same here on ubuntu 16.04, "le fichier ou dossier a été ignoré car il est masqué". I lose the amount of data transfered information because of the information displayed. Make difficult to see real problems.

@cloo
Copy link

cloo commented Aug 2, 2019

Same here on Windows 10 client / Ubuntu 18.04 server / Nextcloud 16.0.3

@Derridaralalala
Copy link

This is still an issue in MAC OS clients from 2.5.2 up to 2.6 RC1. Crazy.

@keunes
Copy link

keunes commented Sep 16, 2019

I was going to create a new issue but GitHub suggested me this one instead. I had the impression I already had similar issues under 2.3, but I just upgraded to 2.5.3daily-Win64 (build 20190725) on Windows 10 and I (still) have the issue for sure. Indeed the most annoying thing is to be wrongly suggested that things are off while all actually is fine, as indicated by @LukeLR.

@keunes
Copy link

keunes commented Sep 16, 2019

Also experiencing this issue?

Please consider giving a thumbs-up to the original post. It can help indicate this issue as one that's affecting many users.

@paulsommer
Copy link

It's hard to believe that such a simple issue is not fixed after one year. Seems as if the developer is not interested and someone has to fork the whole thing to fix that annoying error.

@Derridaralalala
Copy link

@paulsommer agree. the only working version in this matter seems to be Nextcloud-2.3.3.84. Even Version 2.6.0rc1 does not fix the issue(s). (@camilasan)

@LukeLR
Copy link

LukeLR commented Sep 22, 2019 via email

@camilasan
Copy link
Member

camilasan commented Sep 23, 2019

I can't reproduce the problem mentioned by @Germano0. I see that in my file manager a conflict file has the same icon as an ignored file but that is not the case in the client main window. Would you - all affected by the problem - mind sharing some screenshots?

@tomdereub
Copy link
Contributor

tomdereub commented Sep 23, 2019

Here an example with Nextcloud 2.5.3daily-Win64 (build 20190725), on windows 10, in the activity tab:

image

@keunes
Copy link

keunes commented Sep 24, 2019

Using Version 2.5.2git on Ubuntu 18.04.3 LTS. 3 types of 'errors' that shouldn't be (hidden, black list, ignore list):
Screenshot from 2019-09-24 09-17-14

@TrilceAC
Copy link

TrilceAC commented Sep 24, 2019

Some time ago, I thought that I was suffering this issue. In reality I did not:

In my case, there were files that had sync issues because they were written twice or more times in really shorts periods of time. Think about a small sqlite database, or when coding or writing a document, when you save and immediately after saving you realise about a typo: I save, I fix the typo and save again in less than a few seconds. In those situations Nextcloud isn't fast enough to properly make the whole synchronization procedure. This causes a local conflict in a file that you don't expect. And this changes the icon in the notifications bar from green to yellow.

The problem is that I hardly realise about this issue because when I go to the Activity tab in Settings: I have many ignored files that are reported with the yellow flag. This long list makes me difficult to find the actual conflict files.

I program in python under a nextcloud directory. Among others, I exclude the *.pyc files, but they are reported in the activity tab, which is fine, but the list is long, and therefore I hardly find actual conflicting files when there are. If for some reason I store a small sqlite database that I have forgotten to exclude for synchronization, and it is quickly changed many times by the program, this is a perfect candidate for conflict. In the end, it is not critical, since the latest version of the file is stored locally, but it might be somehow annoying.

Therefore, I recommend you to check twice that in fact you are not suffering from this. There might be a silly conflict hidden among that long list of ignored files.

Hope this helps someone.

Edit 1: git is also a usual culprit of conflicts.

@tomdereub
Copy link
Contributor

Ok, so we don't speak about the same issue. For me nextcloud's icon is green, I don't have conflicts for now, but I just don't want the ignored files to appear in the activity tab. Otherwise, when a conflicts appears, it's almost impossible to find which file is concerned because itqs lost in the middle of those thousand lines of "ignored files".

@camilasan camilasan added this to the 2.7 🌟 UI improvements milestone Sep 26, 2019
@David-Lor
Copy link

David-Lor commented Oct 5, 2019

Seems to be fixed on version 2.6.0 :)
EDIT: Version 2.6.0 @ Ubuntu (apt & appimage)

@alexdetsch
Copy link

@David-Lor No, for me it was not resolved. It still uploaded all the previously ignored files :/

@bunjes
Copy link

bunjes commented Oct 9, 2019

Sorry, but the issue is still present in Version 2.6.0stable (build 20190927) on MacOS: Greenish
Conflict Panel not clickable and exclamation-mark icon:
tmp

@arenaq
Copy link

arenaq commented Oct 12, 2019

Thank you Nextcloud for spending 2 hours to fix this after updating to new version. Solution? SSH to server, check the files against backup - OK. Run php occ files:scan. Delete local files and reinstall the application. Do the sync. Find out this issue is here for one year. Look for an alternative. Lived happily every after.

PS: Forgot to mention that after reinstalling the app you also have to fix this hilarious bug #978

@keunes
Copy link

keunes commented Oct 13, 2019

Thanks @camilasan for adding this to the 2.7 milestone! :)

@f5oto
Copy link

f5oto commented Nov 28, 2019

I had this issue. Many files not synced due to being hidden. Yello exclamation.
It was caused when I used cp to copy some files over manually and then ran the occ scan command against that particular folder:

sudo -u www-data php occ files:scan --path="user/files/backup"

Unfortunately, it took AGES to run the command on a small folder to I killed it only to find that it was duplicating the folder structure within the backup folder and caused a corruption. I had to then manually remove these files from my desktop sync location by enabling the "view hidden files" in windows. I search ed for .~ and removed the temp/corrupted files and cleaned up the directories and then all was well.

Moral of the story, done use the --path switch with occ.

@er-vin er-vin added the confirmed bug approved by the team label Jun 10, 2020
@er-vin
Copy link
Member

er-vin commented Jun 11, 2020

OK, so that particular area changed a lot in the new GUI. Also this issue ticket went in plenty of different direction which makes it really hard to act on. I will close it for now, if some concern is still left unanswered by the upcoming 2.7, please open a new ticket focusing only on that particular concern.

@er-vin er-vin closed this as completed Jun 11, 2020
@keunes
Copy link

keunes commented Jun 11, 2020

that particular area changed a lot in the new GUI

Didn't know a GUI overhaul was coming to us - great :) Is there a place where we can see (visually) what 2.7 will/might look like?

@misch7
Copy link
Member

misch7 commented Jun 11, 2020

Didn't know a GUI overhaul was coming to us - great :) Is there a place where we can see (visually) what 2.7 will/might look like?

Sure, you can try the beta :)

https://github.com/nextcloud/desktop/releases/tag/v2.7.0-beta1

(Some of the 2.7-related issues in GitHub also contain work-in-progress screenshots.)

@Grunthos
Copy link

I'm still seeing this very unhelpful error in the current windows desktop client. I can see nothing in the tiny popup dialog that indicates a conflict, and searching for files with a name containing 'conflict' produces no results.

How can I get a list like we used to get before the dialog was turned into the tiny and unusable popup that it is now? Are there log files somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests