Fix for network validation issues on wireless (fixes Issue #4331) #5542
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
==========================================
- Coverage 59.28% 58.94% -0.35%
==========================================
Files 143 143
Lines 18445 18314 -131
==========================================
- Hits 10936 10795 -141
- Misses 7509 7519 +10 |
|
This fix solved the problem for me too |
Co-authored-by: Claudio Cambra <[email protected]> Signed-off-by: Owen Marshall <[email protected]>
|
AppImage file: nextcloud-PR-5542-9a55ef9d47ea9ceb4139afaec62db4c366a299b0-x86_64.AppImage |
| const auto accounts = AccountManager::instance()->accounts(); | ||
| for (auto account : accounts) { | ||
| account->freshConnectionAttempt(); | ||
| } |
There was a problem hiding this comment.
should you not call this only if the error is related to network issues ?
for example, imagine the desktop client doing a get request that will return a 404 result code, you do nto want to execute freshConnectionAttempt() after a 404
an easy way to spot the issue is to have a client wihtout end-to-end encryption enabled but a server with the app installed and enabled
then if you open the settings dialog, we check if the server has a public end-to-end encryption key, gets a 404 and disconnects the session turning the tray icon to the disconnected state for some time before turning connected again
second thing is that most probably such a fix would be needed for all credentials classes not only when using the web flow v2 related code (i.e. this WebFlowCredentials class) but also other authentication methods
|
Do you have any estimation of which client version this will make it into? I have this problem on all of my Windows 10 and Linux Mint clients. |
|
Hi. I also have this issue and are hoping for a fix soon. |
|
This fixes for me. Please include it as it's kind of broken without. Who wants a sync tool that constantly goes offline?! |
|
Hello, Thank you for your contribution to the Desktop Client with this pull request. We truly value your support and hope to see more contributions from you in the future! Best regards, |
There is an issue on linux (and maybe other OSes?) where reconnecting to the wifi network leads to a network validation error (unsure why, but previous code comments suggest it stems from an issue in QNAM). See Issue #4331 for more details and comments.
This PR uses the procedure from
gui/networksettings.cppto force a fresh connection attempt following a validation error. This ultimately leads to code inAccountState::checkConnectivity()that appears to have added to catch very similar issues (but was never reached in this error case).