Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: nextcloud 3.5.2/3.5.3 appimage always requires authorization #4715

Closed
8 tasks done
tigernero79 opened this issue Jul 10, 2022 · 48 comments · Fixed by #4830
Closed
8 tasks done

[Bug]: nextcloud 3.5.2/3.5.3 appimage always requires authorization #4715

tigernero79 opened this issue Jul 10, 2022 · 48 comments · Fixed by #4830

Comments

@tigernero79
Copy link

⚠️ Before submitting, please verify the following: ⚠️

Bug description

after configuring the installation URL and accessing the synchronized folders at the next restart, nextcloud always starts Chrome to always request authorization to access the site as occurs in the configuration step

Steps to reproduce

  1. Right click on the file
  2. Click on Share Options
  3. The share dialog does not display the option to share by e-mail
    ...

Expected behavior

When clicking on the share dialog, share by e-mail should be an option.
...

Which files are affected by this bug

All

Operating system

Linux

Which version of the operating system you are running.

Ubuntu 22.04

Package

Appimage

Nextcloud Server version

24.0.2

Nextcloud Desktop Client version

3.5.2

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

after configuring the installation URL and accessing the synchronized folders at the next restart, nextcloud always starts Chrome to always request authorization to access the site as occurs in the configuration step

Additional info

No response

@psyonara
Copy link

I can confirm this, I have reproduced the issue.

@Steve-Z
Copy link

Steve-Z commented Jul 11, 2022

I have the same problem but with differences from the issue as reported above:

  1. Not a fresh install. I updated appimage from 3.5.1.
  2. I do not use encryption.
  3. OS is Pop!_OS 22.04.
  4. Nextcloud 24.0.1 (snap)
  5. I do not use an external user-backend.

@dave-kennedy
Copy link

Same issue here after upgrading from 3.5.1. Except the OP forgot to edit the repro steps and expected behavior, which were copied from the bug template. Has nothing to do with sharing.

@Wikinaut
Copy link

same here. Linux Mint 20.3

@otapol
Copy link

otapol commented Jul 13, 2022

Také zde ubuntu-5.4.0-121-generic

@davidM-tugraz
Copy link

I have the same problem on Fedora 36.
Gnome 42.3.1
Nextcloud server 24.0.1

@Cuthbert1337
Copy link

same issue on Ubuntu 22.04 + Fedora 36

also if authorized it is considerably slower than the previous version! Opening settings requires several seconds. Up to 3.5.1 it just worked so I returned to that.

@kz26
Copy link

kz26 commented Jul 18, 2022

Experiencing this same issue on Ubuntu 20.04 connecting to a Nextcloud 23.0.6 server. Works again with the old 3.5.1 AppImage.

@kevinflynn387
Copy link

kevinflynn387 commented Jul 18, 2022

I have the same issue using Nextcloud-3.5.2-x86_64.AppImage desktop client on my device which is running Linux Mint 20.3 cinnamon (Kernel 5.4.0-122-generic).
The Nextcloud-3.5.1-x86_64.AppImage works still fine without any issues.

Nextcloud Server version is 24.0.2

@CedricGoby
Copy link

Hi,
Same behaviour here using Xubuntu 20.04 (Xfce 4.14) - Linux version 5.15.0-41-generic.
Nextcloud-3.5.1-x86_64.AppImage works fine
Nextcloud Server version : 23 to 24

@iadegesso
Copy link

Same issue on my Gentoo with GNOME 42. Moreover, it continuously asks to store credentials in the KDE KeyWallet.

Iade

@olaulau
Copy link

olaulau commented Jul 20, 2022

same for me

@schlimmchen
Copy link

Same on debian bullseye (with backports) using the 3.5.2 AppImage.

I'd like to add that the whole app seems unresponsive. For me it takes quite long until the windows pop up requesting authorization. When trying to open the settings window by clicking "Settings" from the main menu, it also takes very long until the settings window pops up.

@joaewik
Copy link

joaewik commented Jul 21, 2022

After installation of Version 3.5.2 I had to login at every start. When installing 3.5.1 again, only the first start needed a login, as before.
I’m using Ubuntu 22.04 (Gnome) and it seems that there is a problem with gnome-keyring which is used by 3.5.1 but not by 3.5.2.

@matho10
Copy link

matho10 commented Jul 22, 2022

Same problem here, my nextcloud desktop (3.5.2) is freshly installed through snap on Ubuntu 22.04. I have two accounts so the authentication process is really painful...
I'm also using nextcloud desktop (3.1.3) on macOS 12.4, it works fine.

@MartNytrm
Copy link

Same issue here with version 3.5.2 (AppImage). Was no problem with 3.5.1 and going back to 3.5.1 solves the authorization issue.
(On 5.15.55-1-MANJARO, Cinnamon 5.4.3-1, gnome-keyring 42.1-1)

Maybe the issue is somehow related to https://github.com/nextcloud/desktop/issues/2573

@rupi-lol
Copy link

I checked what was requested on d-bus:

method call time=1658862037.895816 sender=:1.1509 -> destination=org.freedesktop.DBus serial=15 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch string "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',arg0='org.kde.kwalletd5'" method call time=1658862037.895878 sender=:1.1509 -> destination=org.freedesktop.DBus serial=16 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner string "org.kde.kwalletd5"

Looks like they moved from the generic d-bus Secret Service API to the special KDE version of it.

Introducing a breaking change in a minor version update without a big fat warning is not nice..

@dave-kennedy
Copy link

Introducing a breaking change in a minor version update without a big fat warning is not nice..

No but it is typical for this app.

@MartNytrm
Copy link

Looks like they moved from the generic d-bus Secret Service API to the special KDE version of it.

Introducing a breaking change in a minor version update without a big fat warning is not nice..

As I understand your discovery, @rupi-lol , I assume that means:

  1. It is not a bug.
  2. For everybody experiencing this issue/behavior (the ones without KDE respectively KWallet?) this issue will persist. E.g., there was nothing related in changelog of 3.5.3 and therefore of course 3.5.3 doesn't change a thing for me.

Is there a possibility that this "breaking change" happend unintentionally?

@tigernero79 tigernero79 changed the title [Bug]: nextcloud 3.5.2 appimage always requires authorization [Bug]: nextcloud 3.5.2/3.5.3 appimage always requires authorization Jul 30, 2022
@tigernero79
Copy link
Author

unfortunately this bug is still present even in the new version 3.5.3 😢😏

@rupi-lol
Copy link

Is there a possibility that this "breaking change" happend unintentionally?

If everybody in development and testing uses KDE it may be that nobody even realized what they had done. Would not be the first time something like that happens and I can totally see this slipping through testing.

What I find problematic is that they seem to ignore this issue... will this change rolled back? Do we need to find another sync solution? .. Some kind of comment by a dev would be really appreciated.

@user23498723452
Copy link

user23498723452 commented Jul 30, 2022

I had experienced another even worse access issue with ssl config (login failed) , and they ignored it for months. I had to run the old version forever.

I suspect they have very limited resources, and unfortunately they may not be an experienced dev working on this area of the code, which is horrifying for such an important aspect of the solution.

If anyone can share the process to get to an older build on Ubuntu 20 lts that would be appreciated

@DLeich
Copy link

DLeich commented Jul 31, 2022

Just noting I'm having the same issue too. 3.5.3 appimage on Ubuntu 22.04. I can confirm that revering back to 3.5.1 works though.

@rupi-lol
Copy link

rupi-lol commented Aug 2, 2022

I have no experience in C++ or the Qt framework so I'm a bit lost in debugging this. But: a quick look in https://github.com/nextcloud/desktop/tree/master/src/libsync/creds (the only place in the code I found dealing with keychain connections) showed no change at all.

So I tried to build nextcloud desktop 3.5.3 against the Qt5 shipped with my system (Debian 11.4, current stable): no problem at all, uses d-bus Secret Agent API.

So it looks like the bundled qtkeychain is at fault here.

@moppman
Copy link

moppman commented Aug 2, 2022

So it looks like the bundled qtkeychain is at fault here.

I don't think so. Provided they're still building AppImages the same way, they're still using qtkeychain v0.10.0 from 2019.

@zevlee
Copy link

zevlee commented Aug 3, 2022

The authorization issue persists in version 3.5.4. Also, opening the settings window still takes several seconds as mentioned by @Cuthbert1337.

@rupi-lol
Copy link

rupi-lol commented Aug 3, 2022

After discovering that the build script uses a public available docker image as build envirionment I tried it and built a current snapshot appimage: the authorization issue is there. And as @moppman saw it uses qtkeychain v0.10 (same as I did with my local build). So the culprit left would be the linuxdeployqt appimage used.

@rupi-lol
Copy link

rupi-lol commented Aug 3, 2022

Confirmed the problem derives from linuxdeployqt. Built an appimage with build-daily.sh, changed the continuous appimage to release '8' from 13.6. 2021 (the only other option would be even older and labeled do not use).
Authentication using d-bus Secret Agent works like expected (well.. at least in my envirionment).

@tigernero79
Copy link
Author

I respect those who put effort, time and dedication to make it possible in this case to use a functional client for nextcloud. but I wonder is it possible that no developer from the 3.5.2 release today we are at 3.5.4 has the slightest thought of testing appimage on a Debian distribution? because it is absurd that after 2 version releases no control by nextcloud has solved such an obvious problem. these are the problems for which one then asks does it make sense to use free applications? I say after 2 version releases who does tests?

@x29a
Copy link

x29a commented Aug 5, 2022

Confirmed the problem derives from linuxdeployqt. Built an appimage with build-daily.sh, changed the continuous appimage to release '8' from 13.6. 2021 (the only other option would be even older and labeled do not use). Authentication using d-bus Secret Agent works like expected (well.. at least in my envirionment).

can you describe how you built it? so which docker container to spawn and then run the linked script from @moppman?

and thanks for opening an issue at linuxdeployqt <3

@moppman
Copy link

moppman commented Aug 5, 2022

@x29a Checkout https://github.com/nextcloud/client-building and then run build-daily.sh in the linux subfolder (without the uploading part at the end of the script, of course).

Edit: You'll need to adapt build-appimage-daily.sh in the same folder if you want to use another linuxdeployqt version.

@pnewbery
Copy link

pnewbery commented Aug 5, 2022

It makes me wonder if the Nextcloud support people are even monitoring this thread / channel. It would appear from @x29a 's solution above, that this is a trivial problem to fix, yet it has been present in 2 releases since it was first reported. I can confirm that it is still present on 3.5.4 running on LinuxMint 20.3.

@x29a
Copy link

x29a commented Aug 5, 2022

@moppman thanks for the pointer, with that i verified @FredericLespez PR #103 of the clientbuilding project and it works just fine. What a relief!

@pnewbery im not sure how to raise more awareness for this issue. Somebody stated somewhere the forums, though there is an entry already.

While searching for this problem i stumbled accross this debian bug - not sure if people there could help.

@zakutin
Copy link

zakutin commented Aug 16, 2022

The issue still persists on version 3.5.4 on Ubuntu 22.04.1.

@nerdling
Copy link

nerdling commented Aug 16, 2022

The fix will be in 3.6.0.

While waiting for the release, you can run a 3.5.50 or 3.6.0 RC1.

@Anarch157a
Copy link

I'm using 3.6.0 AppImage and the issue persists, It asks for authorization everytime I open the app.

@pnewbery
Copy link

pnewbery commented Oct 6, 2022

NOT FIXED in Appimage 3.60. Now being asked for keyring login on Linumint 20.1

@BMerz
Copy link
Contributor

BMerz commented Oct 9, 2022

Appimage 3.6.0 with Debian fixed the issue for me.

@pnewbery
Copy link

OK, I've just discovered what I think is the reason for the login keyring always asking for my password before Nextcloud will connect.
I was doing a bit of surfing looking for possible answers and one of the topics I found mentioned Seahorse. I opened Seahorse to check the entries in my keyring and found that I had two Nextcloud app passwords for each of the two servers the client logs into. I've no idea how this has occurred and can only surmise it happened because of all of the issues I experienced with the appimage. Now I'm faced with the issue of knowing which is the correct appimage password for each server and which one to delete or whether to start all over again. However I'm not sure how to do that. I suspect that if I delete all of the Nextcloud keyring entries, the solution may present itself, but could someone confirm this please?

@sunjam
Copy link

sunjam commented Nov 11, 2022 via email

@ppascher
Copy link

ppascher commented Nov 11, 2022

I also have this issue

> nextcloud -v
Nextcloud version 3.6.2git
Git revision 2a703f26b7f77451ad157fcaa215d7e99a4b4015
Using Qt 5.15.7, built against Qt 5.15.7
Using Qt platform plugin 'wayland'
Using 'OpenSSL 3.0.7 1 Nov 2022'
Running on Arch Linux, x86_64

I noticed Nextcloud saves 2 entries to my secret service provider (KeepassXC) although I only connect to one server.
Whenever I restart nextcloud-client, keepass asks me whether I want to allow it to access the secret service entry and whether to remember this decision. This worked fine until about 2-3 weeks ago. Other apps using keepassxc secret service still work fine.

I then tried deleting one of the two nextcloud entries (the first one, did not work if I deleted the second one) in the secret service, started nextcloud and it used the remaining entry without requiring confirmation. But it readded a second entry after which the next restart required confirmation again. If I deleted that most recent added entry the next restart worked fine again but added the (wrong) second entry and so on.

So I assume there is an issue with the two entries being created by nextcloud.

@sunjam
Copy link

sunjam commented Nov 11, 2022 via email

@ppascher
Copy link

I was not able to find the issue you mentioned but opened a new one on the keepaasxc github.
Also it seems to be an issue with keepassxc as you said. After downgrading it from 2.7.4 to 2.7.1 the issue is gone.
Sorry for the noise and thank you for steering me in the right direction.

@pnewbery
Copy link

I can confirm that the issue is fixed in Linux appimage 3.6.2

@Anarch157a
Copy link

I'm on 3.6.2, appimage on Debian unstable and the issue persists. I have to grant authorization everytime I open the app.

@tigernero79
Copy link
Author

On appimage 3.6.4 problem Is resolve

@lapineige
Copy link

lapineige commented Dec 24, 2022

AppImage 3.6.4, Kubuntu 22.10, problem not solved.

@lapineige
Copy link

Any KDE user still experiencing the issue ? See: #2573 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.