Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Share link label #3793

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Feature/Share link label #3793

merged 2 commits into from
Sep 21, 2021

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Sep 14, 2021 •
edited
Loading

@camilasan camilasan marked this pull request as draft September 14, 2021 17:44
@camilasan camilasan changed the title Feature/link share label Feature/Share link label Sep 14, 2021
@camilasan camilasan mentioned this pull request Sep 14, 2021
Open
4 tasks
@camilasan camilasan force-pushed the feature/link-share-label branch 3 times, most recently from 18a9cd6 to 551729b Compare September 14, 2021 19:27
mgallien
mgallien reviewed Sep 15, 2021
View reviewed changes
src/gui/ocssharejob.cpp Outdated Show resolved Hide resolved
src/gui/sharelinkwidget.cpp Outdated Show resolved Hide resolved
src/gui/sharelinkwidget.cpp Outdated Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
src/gui/ocssharejob.cpp Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/link-share-label branch from 551729b to e6299a0 Compare September 20, 2021 11:08
@camilasan camilasan marked this pull request as ready for review September 20, 2021 11:08
@mgallien mgallien requested a review from FlexW September 20, 2021 13:12
@mgallien
Copy link
Collaborator

please do not forget to clean history @camilasan

@camilasan
Copy link
Member Author

/rebase

@allexzander allexzander self-requested a review September 20, 2021 16:24
allexzander
allexzander approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @camilasan Please don't forget to clean-up the history

@camilasan camilasan force-pushed the feature/link-share-label branch from 694d9d3 to 9796b2f Compare September 20, 2021 16:47
FlexW
FlexW reviewed Sep 20, 2021
View reviewed changes
src/gui/sharelinkwidget.h Outdated Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
src/gui/sharemanager.h Outdated Show resolved Hide resolved
src/gui/sharemanager.h Show resolved Hide resolved
src/gui/sharelinkwidget.cpp Outdated Show resolved Hide resolved
src/gui/sharelinkwidget.cpp Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/link-share-label branch from 9796b2f to b231007 Compare September 21, 2021 09:28
@mgallien
Copy link
Collaborator

/rebase

@mgallien mgallien added this to the 3.4.0 milestone Sep 21, 2021
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3793-db447c4676d5717805f2e821ecfed4ba0c5b9b5e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 4992977 into master Sep 21, 2021
@mgallien mgallien deleted the feature/link-share-label branch September 21, 2021 12:08
@camilasan camilasan mentioned this pull request Oct 2, 2021
Merged
@joshtrichards joshtrichards mentioned this pull request Nov 27, 2023
Closed
@PeggyFree
Copy link

Hello,

I love this feature. Unfortunately when I create a public share on a folder belonging to another Nextcloud user of my organization, the custom label and the note are not visible. The customized data is saved with no error message, but when showing the public link on a incognito browser, I see no custom label nor note, contrary to a public share created on my own files.

Using Nextcloud 27.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlexW FlexW FlexW left review comments

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camilasan @mgallien @nextcloud-desktop-bot @PeggyFree @allexzander @FlexW