Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Download Button for Updates on macOS (again) #3254

Closed
jonasgarstick opened this issue May 3, 2021 · 6 comments
Closed

No Download Button for Updates on macOS (again) #3254

jonasgarstick opened this issue May 3, 2021 · 6 comments
Labels
bug confirmed bug approved by the team os: 🍎 macOS

Comments

@jonasgarstick
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

After checking for updates manually or get the notification from the client there is an update I would expect to get a clickable button (link) to download the update.

Actual behaviour

The message contains the link in plain text "https://nextcloud.com/install/?pk_campaign=clientupdate#install-clients". You cannot copy or click the link directly.

Steps to reproduce

  1. Manually install client 3.2.0
  2. Open Nextcloud Preferences
  3. Check for updates and check the message

Client configuration

Client version:
3.2.0 (macOS)

Operating system:
macOS Catalina 10.15.7

OS language:
german
nc-update-download
notification

@claucambra
Copy link
Collaborator

Hi all, the client now ships with an autoupdater which provides a popup with several options when an update is available. The autoupdater handles downloading and installing the relevant update, delaying the update or dismissing it entirely. #4466

In situations where this autoupdater has been disabled the standard update notification is now clickable and will take you to the client download page. #3732

Thanks for reporting!

@foss-
Copy link

foss- commented Jun 9, 2022

macOS 12.4
nextcloud Desktop 3.5.1

debug	13:03:28.156855+0200	Nextcloud	Bundle: <private>, key: No valid update information could be loaded., value: , table: Sparkle, localizationName: (null), result: No valid update information could be loaded.
debug	13:03:28.156899+0200	Nextcloud	Bundle: <private>, key: Cancel Update, value: , table: Sparkle, localizationName: (null), result: Cancel Update

Log: https://bin.disroot.org/?25a394687a954144#Gje8c2PpMJBXoUXQiMGu4sGsyQu9M1jnWYF298Jyf4Hn

error
Are you sure this is fixed?

@claucambra
Copy link
Collaborator

Yes, this is a separate issue -- seems like at the moment Sparkle is taking "no update available" from our servers as "no valid update information". When there is a valid update the update popup appears and the update is correctly downloaded and installed. Looking into this

@foss-
Copy link

foss- commented Jun 9, 2022

Where is this separate issue tracked?

@claucambra
Copy link
Collaborator

Sorry, by "issue" I meant problem 😅 It was mentioned here #3974 (comment) but no issue was opened, feel free to open an issue

@foss-
Copy link

foss- commented Jun 9, 2022

Followup: #4627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug approved by the team os: 🍎 macOS
Projects
None yet
Development

No branches or pull requests

4 participants