Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing QtSingleApplication with something else #2364

Closed
tilosp opened this issue Sep 4, 2020 · 3 comments
Closed

Consider replacing QtSingleApplication with something else #2364

tilosp opened this issue Sep 4, 2020 · 3 comments

Comments

@tilosp
Copy link
Member

tilosp commented Sep 4, 2020

QtSingleApplication relies heavily on pids, this breaks if two client processes get the same pid.
This is for example the case in the flatpak sandbox. See: flathub/com.nextcloud.desktopclient.nextcloud#12

This is why I propose to replace QtSingleApplication with something else.
One alternative would be for example: https://github.com/itay-grudev/SingleApplication

I have opened this issue to get feedback on this idea.

@er-vin
Copy link
Member

er-vin commented Sep 8, 2020

Yes, I'm totally for replacing QtSingleApplication which is a very old piece of a forked code we're carrying. How would you envision the transition though? I see they recommend git submodule but I'm not too hot on that, that said if it's unpackaged territory we might have no choice...

@fkrull
Copy link

fkrull commented Jun 13, 2023

But a Git submodule is not any worse than the status quo, right? QtSingleApplication is fully vendored so a submodule would arguably an improvement. And having a vendored-but-working implementation would still be preferable to having a vendored-and-subtly-not-working implementation.

@Rello
Copy link
Contributor

Rello commented Nov 25, 2024

Hello,

thank you for opening the request.
The client has improved a lot since the ticket was opened.
Can you support us and check if it is still relevant? In this case we appreciate a new ticket or a comment here.
Thank you for your support

@Rello Rello closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants