Skip to content

Commit

Permalink
fix compilation issues after rebase
Browse files Browse the repository at this point in the history
Signed-off-by: Matthieu Gallien <[email protected]>
  • Loading branch information
mgallien committed Apr 5, 2024
1 parent a4ffefb commit d24a14b
Show file tree
Hide file tree
Showing 11 changed files with 19 additions and 46 deletions.
13 changes: 0 additions & 13 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,19 +51,6 @@ else()
)
endif()

find_package(Qt${QT_MAJOR_VERSION}WebEngine ${REQUIRED_QT_VERSION} CONFIG QUIET)
if(NOT BUILD_WITH_WEBENGINE)
set_package_properties(Qt${QT_MAJOR_VERSION}WebEngine PROPERTIES
DESCRIPTION "Qt${QT_MAJOR_VERSION} WebEngine component."
TYPE RECOMMENDED
)
else()
set_package_properties(Qt${QT_MAJOR_VERSION}WebEngine PROPERTIES
DESCRIPTION "Qt${QT_MAJOR_VERSION} WebEngine component."
TYPE REQUIRED
)
endif()

find_package(Qt${QT_VERSION_MAJOR}WebEngineCore ${REQUIRED_QT_VERSION} CONFIG QUIET)
if(APPLE)
set_package_properties(Qt${QT_VERSION_MAJOR}WebEngineCore PROPERTIES
Expand Down
1 change: 1 addition & 0 deletions src/common/remotepermissions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include "remotepermissions.h"

#include <QVariant>
#include <QLoggingCategory>

#include <cstring>
Expand Down
31 changes: 8 additions & 23 deletions src/gui/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
project(gui)
find_package(Qt${QT_MAJOR_VERSION} REQUIRED COMPONENTS Widgets Svg Qml Quick QuickControls2 QuickWidgets Xml Network)
find_package(KF5Archive REQUIRED)
find_package(KF5GuiAddons)

if(QUICK_COMPILER)
if (${QT_VERSION_MAJOR} STREQUAL "5")
set(REQUIRED_QT_VERSION "5.15.0")
find_package(Qt${QT_MAJOR_VERSION} ${REQUIRED_QT_VERSION} CONFIG REQUIRED QuickCompiler)
set_package_properties(Qt5QuickCompiler PROPERTIES
DESCRIPTION "Compile QML at build time"
TYPE REQUIRED
)
endif()
endif()
find_package(KF6Archive REQUIRED)
find_package(KF6GuiAddons)

if (NOT TARGET Qt::GuiPrivate)
message(FATAL_ERROR "Could not find GuiPrivate component of Qt. It might be shipped as a separate package, please check that.")
Expand Down Expand Up @@ -58,11 +47,7 @@ set(client_UI_SRCS
wizard/welcomepage.ui
)

if(Qt5QuickCompiler_FOUND)
qtquick_compiler_add_resources(client_UI_SRCS ../../resources.qrc ${CMAKE_SOURCE_DIR}/theme.qrc)
else()
qt_add_resources(client_UI_SRCS ../../resources.qrc ${CMAKE_SOURCE_DIR}/theme.qrc)
endif()
qt_add_resources(client_UI_SRCS ../../resources.qrc ${CMAKE_SOURCE_DIR}/theme.qrc)

set(client_SRCS
accountmanager.h
Expand Down Expand Up @@ -406,7 +391,7 @@ set( final_src
)

if(Qt${QT_MAJOR_VERSION}Keychain_FOUND)
list(APPEND libsync_LINK_TARGETS qt5keychain)
list(APPEND libsync_LINK_TARGETS Qt6::keychain)
endif()

# add executable icon on windows and osx
Expand Down Expand Up @@ -568,13 +553,13 @@ target_link_libraries(nextcloudCore
Qt::Quick
Qt::QuickControls2
Qt::QuickWidgets
KF5::Archive
KF6::Archive
)

if(KF5GuiAddons_FOUND)
if(KF6GuiAddons_FOUND)
target_link_libraries(nextcloudCore
PUBLIC
KF5::GuiAddons
KF6::GuiAddons
)
add_definitions(-DHAVE_KGUIADDONS)
endif()
Expand All @@ -591,7 +576,7 @@ foreach(FILE IN LISTS client_UI_SRCS)
set_property(SOURCE ${FILE} PROPERTY SKIP_UNITY_BUILD_INCLUSION ON)
endforeach()

if(Qt5WebEngine_FOUND AND Qt5WebEngineWidgets_FOUND)
if(Qt6WebEngine_FOUND AND Qt6WebEngineWidgets_FOUND)
target_link_libraries(nextcloudCore PUBLIC Qt::WebEngineWidgets)
endif()

Expand Down
2 changes: 1 addition & 1 deletion src/gui/accountstate.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ void AccountState::checkConnectivity()

// If we don't reset the ssl config a second CheckServerJob can produce a
// ssl config that does not have a sensible certificate chain.
account()->setSslConfiguration(QSslConfiguration());
account()->setSslConfiguration(QSslConfiguration::defaultConfiguration());
//#endif
conValidator->checkServerAndAuth();
}
Expand Down
2 changes: 1 addition & 1 deletion src/gui/application.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ void Application::setupConfigFile()
QT_WARNING_POP
setApplicationName(_theme->appName());

auto oldDir = QStandardPaths::writableLocation(QStandardPaths::DataLocation);
auto oldDir = QStandardPaths::writableLocation(QStandardPaths::AppDataLocation);

// macOS 10.11.x does not like trailing slash for rename/move.
if (oldDir.endsWith('/')) {
Expand Down
1 change: 1 addition & 0 deletions src/gui/folder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,7 @@ void Folder::slotWatchedPathChanged(const QStringView &path, const ChangeReason
if (!pinState || *pinState != PinState::Excluded) {
if (!_vfs->setPinState(relativePath.toString(), PinState::Excluded)) {
qCWarning(lcFolder) << "Could not set pin state of" << relativePath << "to excluded";
}
}
return;
} else {
Expand Down
2 changes: 2 additions & 0 deletions src/gui/folder.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include <QObject>
#include <QStringList>
#include <QUuid>
#include <QSet>

#include <set>
#include <chrono>
#include <memory>
Expand Down
2 changes: 1 addition & 1 deletion src/gui/generalsettings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ void GeneralSettings::slotUpdateInfo()
if (ocupdater) {
connect(ocupdater, &OCUpdater::downloadStateChanged, this, &GeneralSettings::slotUpdateInfo, Qt::UniqueConnection);
connect(_ui->restartButton, &QAbstractButton::clicked, ocupdater, &OCUpdater::slotStartInstaller, Qt::UniqueConnection);
connect(_ui->restartButton, &QAbstractButton::clicked, qApp, &QApplication::quit, Qt::UniqueConnection);
//connect(_ui->restartButton, &QAbstractButton::clicked, qApp, &QApplication::quit, Qt::UniqueConnection);

QString status = ocupdater->statusString(OCUpdater::UpdateStatusStringFormat::Html);
Theme::replaceLinkColorStringBackgroundAware(status);
Expand Down
2 changes: 1 addition & 1 deletion src/gui/owncloudsetupwizard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ void OwncloudSetupWizard::slotCheckServer(const QString &urlString)

// And also reset the QSslConfiguration, for the same reason (#6832)
// Here the client certificate is added, if any. Later it'll be in HttpCredentials
account->setSslConfiguration(QSslConfiguration());
account->setSslConfiguration(QSslConfiguration::defaultConfiguration());
auto sslConfiguration = account->getOrCreateSslConfig(); // let Account set defaults
if (!_ocWizard->_clientSslCertificate.isNull()) {
sslConfiguration.setLocalCertificate(_ocWizard->_clientSslCertificate);
Expand Down
7 changes: 2 additions & 5 deletions src/libsync/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
project(libsync)
find_package(KF5Archive REQUIRED)
find_package(KF6Archive REQUIRED)
include(DefinePlatformDefaults)

set(CMAKE_AUTOMOC TRUE)
Expand Down Expand Up @@ -211,7 +211,7 @@ target_link_libraries(nextcloudsync
Qt::WebSockets
Qt::Xml
Qt::Sql
KF5::Archive
KF6::Archive
Qt::Core5Compat
)

Expand All @@ -222,9 +222,6 @@ target_compile_features(nextcloudsync

target_compile_definitions(nextcloudsync PRIVATE OPENSSL_SUPPRESS_DEPRECATED)

find_package(Qt5 REQUIRED COMPONENTS Gui Widgets Svg)
target_link_libraries(nextcloudsync PUBLIC Qt5::Gui Qt5::Widgets Qt5::Svg)

if (NOT TOKEN_AUTH_ONLY)
find_package(Qt${QT_MAJOR_VERSION} COMPONENTS REQUIRED Widgets Svg)
target_link_libraries(nextcloudsync PUBLIC Qt::Widgets Qt::Svg Qt${QT_MAJOR_VERSION}Keychain::Qt${QT_MAJOR_VERSION}Keychain)
Expand Down
2 changes: 1 addition & 1 deletion src/libsync/foldermetadata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ QByteArray FolderMetadata::encryptedMetadata()

QJsonObject files, folders;
for (auto it = _files.constBegin(), end = _files.constEnd(); it != end; ++it) {
const auto file = convertFileToJsonObject(it);
const auto file = convertFileToJsonObject(&(*it));
if (file.isEmpty()) {
qCDebug(lcCseMetadata) << "Metadata generation failed for file" << it->encryptedFilename;
return {};
Expand Down

0 comments on commit d24a14b

Please sign in to comment.