From cebf8b340af2e4b916c0d5e0c127200d32b63e37 Mon Sep 17 00:00:00 2001
From: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Date: Wed, 15 May 2024 15:09:24 +0200
Subject: [PATCH] revert temp changes to get Windows CI being green

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
---
 test/testcfapishellextensionsipc.cpp |  1 -
 test/testlocaldiscovery.cpp          |  3 ---
 test/testpermissions.cpp             |  3 ---
 test/testsynccfapi.cpp               | 20 ++++++++++----------
 4 files changed, 10 insertions(+), 17 deletions(-)

diff --git a/test/testcfapishellextensionsipc.cpp b/test/testcfapishellextensionsipc.cpp
index 12af7724c1cbd..9214c745f6f7f 100644
--- a/test/testcfapishellextensionsipc.cpp
+++ b/test/testcfapishellextensionsipc.cpp
@@ -384,7 +384,6 @@ private slots:
             loop.exec();
             t.detach();
         }
-        QEXPECT_FAIL("", "", Continue);
         QVERIFY(propfindRequestedSpy.count() == dummyFileStates.size());
     }
 
diff --git a/test/testlocaldiscovery.cpp b/test/testlocaldiscovery.cpp
index 9632816ccebf2..fa21c705db7e5 100644
--- a/test/testlocaldiscovery.cpp
+++ b/test/testlocaldiscovery.cpp
@@ -346,9 +346,6 @@ private slots:
         QCOMPARE(completeSpy.findItem(fileWithSpaces4)->_status, SyncFileItem::Status::Success);
         QCOMPARE(completeSpy.findItem(fileWithSpaces5)->_status, SyncFileItem::Status::Success);
         QCOMPARE(completeSpy.findItem(fileWithSpaces6)->_status, SyncFileItem::Status::Success);
-#ifdef Q_OS_WINDOWS
-        QEXPECT_FAIL("", "", Continue);
-#endif
         QCOMPARE(completeSpy.findItem(QStringLiteral(" with spaces "))->_status, SyncFileItem::Status::Success);
     }
 
diff --git a/test/testpermissions.cpp b/test/testpermissions.cpp
index 2e5ad41283650..ba723d76bd719 100644
--- a/test/testpermissions.cpp
+++ b/test/testpermissions.cpp
@@ -227,9 +227,6 @@ private slots:
         //2.
         // File should be deleted
         QVERIFY(!currentLocalState.find("normalDirectory_PERM_CKDNV_/canBeRemoved_PERM_D_.data"));
-#ifdef Q_OS_WINDOWS
-        QEXPECT_FAIL("", "", Abort);
-#endif
         QVERIFY(!currentLocalState.find("readonlyDirectory_PERM_M_/canBeRemoved_PERM_D_.data"));
 
         //3.
diff --git a/test/testsynccfapi.cpp b/test/testsynccfapi.cpp
index 25163554601fa..d537951e9eb4a 100644
--- a/test/testsynccfapi.cpp
+++ b/test/testsynccfapi.cpp
@@ -1280,22 +1280,22 @@ private slots:
         loop.exec();
         t.detach();
 
-        // if (errorKind == NoError) {
-        //     CFVERIFY_NONVIRTUAL(fakeFolder, "online/sub/file1");
-        // } else {
-        //     CFVERIFY_VIRTUAL(fakeFolder, "online/sub/file1");
-        // }
+        if (errorKind == NoError) {
+            CFVERIFY_NONVIRTUAL(fakeFolder, "online/sub/file1");
+        } else {
+            CFVERIFY_VIRTUAL(fakeFolder, "online/sub/file1");
+        }
 
         // Nothing should change
         ItemCompletedSpy completeSpy(fakeFolder);
         QVERIFY(fakeFolder.syncOnce());
         QVERIFY(completeSpy.isEmpty());
 
-        // if (errorKind == NoError) {
-        //     CFVERIFY_NONVIRTUAL(fakeFolder, "online/sub/file1");
-        // } else {
-        //     CFVERIFY_VIRTUAL(fakeFolder, "online/sub/file1");
-        // }
+        if (errorKind == NoError) {
+            CFVERIFY_NONVIRTUAL(fakeFolder, "online/sub/file1");
+        } else {
+            CFVERIFY_VIRTUAL(fakeFolder, "online/sub/file1");
+        }
     }
 
     void testDataFingerPrint()