From 9ccc63aae88834fcdfb8f02a4089c01976890462 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Mon, 15 May 2023 20:05:30 +0800 Subject: [PATCH] Modernise BandwidthManager::absoluteLimitTimerExpired Signed-off-by: Claudio Cambra --- src/libsync/bandwidthmanager.cpp | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/libsync/bandwidthmanager.cpp b/src/libsync/bandwidthmanager.cpp index a313fe5e0c2f9..f5fc3582bcf8d 100644 --- a/src/libsync/bandwidthmanager.cpp +++ b/src/libsync/bandwidthmanager.cpp @@ -389,19 +389,24 @@ void BandwidthManager::switchingTimerExpired() void BandwidthManager::absoluteLimitTimerExpired() { if (usingAbsoluteUploadLimit() && !_absoluteUploadDeviceList.empty()) { - qint64 quotaPerDevice = _currentUploadLimit / qMax((std::list::size_type)1, _absoluteUploadDeviceList.size()); + const auto quotaPerDevice = _currentUploadLimit / qMax((std::list::size_type)1, _absoluteUploadDeviceList.size()); + qCDebug(lcBandwidthManager) << quotaPerDevice << _absoluteUploadDeviceList.size() << _currentUploadLimit; - Q_FOREACH (UploadDevice *device, _absoluteUploadDeviceList) { + + for (const auto device : _absoluteUploadDeviceList) { device->giveBandwidthQuota(quotaPerDevice); qCDebug(lcBandwidthManager) << "Gave " << quotaPerDevice / 1024.0 << " kB to" << device; } } + if (usingAbsoluteDownloadLimit() && !_downloadJobList.empty()) { - qint64 quotaPerJob = _currentDownloadLimit / qMax((std::list::size_type)1, _downloadJobList.size()); + const auto quotaPerJob = _currentDownloadLimit / qMax((std::list::size_type)1, _downloadJobList.size()); + qCDebug(lcBandwidthManager) << quotaPerJob << _downloadJobList.size() << _currentDownloadLimit; - Q_FOREACH (GETFileJob *j, _downloadJobList) { - j->giveBandwidthQuota(quotaPerJob); - qCDebug(lcBandwidthManager) << "Gave " << quotaPerJob / 1024.0 << " kB to" << j; + + for (const auto job : _downloadJobList) { + job->giveBandwidthQuota(quotaPerJob); + qCDebug(lcBandwidthManager) << "Gave " << quotaPerJob / 1024.0 << " kB to" << job; } } }