Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account operating server info to scope updates to supported ones #129

Closed
mgallien opened this issue Jan 29, 2024 · 6 comments · Fixed by #154
Closed

Take into account operating server info to scope updates to supported ones #129

mgallien opened this issue Jan 29, 2024 · 6 comments · Fixed by #154

Comments

@mgallien
Copy link
Collaborator

Given the changes in macOS limiting our ability to support old macOS releases, we need to make sure we do not distribute unsupported release of desktop client to releases unable to install or run it.
Similarly, when we manage to release a desktop client version based on Qt6, we will also have to bump the platform requirements on most operating systems.
Then, we need to ensure we do not send an update based on Qt6 on operating system that are unsupported.
See https://doc-snapshots.qt.io/qt6-6.6/supported-platforms.html#desktop-platforms

@tobiasKaminsky
Copy link
Member

What information needs to be send by client?
What do we need to change on updater server?

@mgallien
Copy link
Collaborator Author

mgallien commented Feb 21, 2024

on windows we would send those info to the updater server:
platform=win32&osRelease=windows&osVersion=10&kernelVersion=10.0.19045&currentArch=x86_64
that would allow to match the windows release and decide if the update is compatible with it
we just need to find out the kernel version matching the releases of windows 10 that we will be compatible with
on linux:
platform=linux&osRelease=debian&osVersion=unknown&kernelVersion=6.6.15-amd64&currentArch=x86_64
that will be definitely more messy as you can see

as indicated in my previous link, the requirements are the following:

@tobiasKaminsky
Copy link
Member

https://sparkle-project.org/documentation/publishing/

add sparkle:minimumSystemVersion and sparkle:maximumSystemVersion for Sparkle

@tobiasKaminsky
Copy link
Member

For Windows we have following osVersions:
QT5:

  • 7
  • 7sp1
  • 8
  • 8.1

QT5/6, check build number:

  • 10
  • 10sp1
  • 10sp4

QT6:

  • 11

Uncertain:
server2008r2
server2008r2sp1
server2012
server2012r2
server2016
server2016sp1
server2019
server2022
unknown

@tobiasKaminsky
Copy link
Member

Mac is easy:
QT5: <11
QT6: >=11

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants