-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploader component design #816
Comments
@nimishavijay FYI I did a small adjustment:
|
Could we have mockups of what it would look like in the following state please?
|
So here's a first draft. I think that the progress part of it should be implemented in the
@skjnldsv what do you mean by this? |
A mockup where no upload is in progress and we can see the |
@marcoambrosini thanks for the mockups! |
Ok, sorry I thought that what was needed was already established but I see now that it's a wider problem that needs solution. @skjnldsv I have a couple of questions: what kind of information about the upload do we have available in the front-end? For example, if I'm doing a batch upload, do I have the progress of every file in the batch? If not do we have at least a confirmation of each uploaded file? |
You will know:
And for each upload in the queue you can request those same stats but for the file only. |
So @skjnldsv as a first step we decided to have the component mentioned above next to the add button, both in photos and files. We will iterate and improve over time but for now we're going to keep it simple. Both error and success state should last for 3 seconds and fade out. |
Please note that the second schreenshot doesn't use this component, so we can take the first one as refrerence only |
@skjnldsv which of the points here are still relevant after merging nextcloud/server#39945 ? :) |
All of them, this was not scheduled for 28 |
As discussed in nextcloud/photos#1785 the uploader component needs to work across all screen sizes. After discussing with @jancborchardt and @szaimen, here is what it could look like:
--color-primary-element
color and--color-background-darker
bg).What do you think? @skjnldsv :)
The text was updated successfully, but these errors were encountered: