-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from icon as VueComponents #947
Comments
This should be no problem, passing components is fine as long as the vue version (2 vs 3) is not mixed. |
Nope, we had that issue in the past. |
but even if the result of the template compiler is different it should work as only the render function will be different. |
🤷We had to downgrade a few vue versions in the past to keep being able to release between apps and libs. Also, same with vue3, it means we're implementing a breaking point. |
Using button icons as VueComponent can lead to issues.
If the components are compiled with different vue versions, this will collide and fail. We had that issue multiple times on variuos other APIs.
Which is why we moved to raw svg as this is the only standard that works whatever js pre-processor or vanilla js code you're handling.
The text was updated successfully, but these errors were encountered: