Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker: Adapt "+" Button styling to the one from the default file listing #888

Closed
AndyScherzinger opened this issue Aug 15, 2023 · 3 comments · Fixed by #892
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AndyScherzinger
Copy link
Contributor

See nextcloud/server#37207 for reference (align with @szaimen - since the change needs to be aligned, if referenced ticket can't make it for 27.1 then go for the current styling (grey background)

Current - Files:
image

Current - Picker
2023-08-15 10_53_06-Files - Nextcloud – Mozilla Firefox

Proposed Files:
image

@AndyScherzinger AndyScherzinger added bug Something isn't working 🍁 2023-Autumn labels Aug 15, 2023
@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📁 Files team Aug 15, 2023
@AndyScherzinger AndyScherzinger added this to the 4.2.0 milestone Aug 15, 2023
@szaimen
Copy link
Contributor

szaimen commented Aug 15, 2023

For my part:

<a href="#" class="button new" aria-expanded="false" aria-label="New file/folder menu">
	<span class="icon icon-add"></span>
	<span>New</span>
</a>
.app-files .actions .button.new {
    position: relative;
    width: unset;
    gap: 5px;
    background-color: var(--color-primary-element-light);
    color: var(--color-primary-element-light-text);
    border: var(--color-border-maxcontrast) 1px solid;
}

@szaimen
Copy link
Contributor

szaimen commented Aug 15, 2023

My PR in nextcloud/server#39884

@susnux
Copy link
Contributor

susnux commented Aug 15, 2023

FilePicker PR: #892

@AndyScherzinger AndyScherzinger moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Aug 15, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants