Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper data-cy selectors for file picker #1001

Closed
juliusknorr opened this issue Sep 14, 2023 · 1 comment
Closed

Add proper data-cy selectors for file picker #1001

juliusknorr opened this issue Sep 14, 2023 · 1 comment

Comments

@juliusknorr
Copy link
Contributor

It would be great to have unique selectors for elements, especially file list entries to pick them during testing

https://docs.cypress.io/guides/references/best-practices

For files we currently only can use the title attribute which doesn't contain the file extension

@susnux
Copy link
Contributor

susnux commented Sep 17, 2023

Duplicate of #924 (partly implemented https://github.com/nextcloud-libraries/nextcloud-dialogs#test-selectors )

@susnux susnux closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants