Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Centralize dependency listings into setup.py? #329

Open
mileswwatkins opened this issue Jun 18, 2018 · 0 comments
Open

Centralize dependency listings into setup.py? #329

mileswwatkins opened this issue Jun 18, 2018 · 0 comments

Comments

@mileswwatkins
Copy link
Contributor

@palewire, following up since you didn't mention this commit one way or another in your PR closure: 017fca0

  • Ideally the requirements.txt and setup.py's core dependencies should have different version pins; setup.py should have the broadest definitions possible, usually with >= or <= or *s, and requirements.txt should be pinned to exact versions. But it doesn't seem like this is necessary or possible on this project. The greater danger is the two lists getting out of sync, which is what centralizing in setup.py would do.
  • Moving dev dependencies to setup.py seems to be the best-practice approach these days, versus having a separate requirements file for the development/testing environment. Plus, then you can have more concise development setup commands; pip install -e .[dev] will install all developer libraries and all core libraries.

Thoughts, all?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant