From c76f4f029f5d936d8ba71379f739971e5653567a Mon Sep 17 00:00:00 2001 From: Galo Navarro Date: Mon, 17 May 2021 11:43:41 +0200 Subject: [PATCH] EXT-SERVICE: match on service.name (#210) * EXT-SERVICE: match on service.name Restoring an original rule that matched based on the pressence of the attribute. Added a warning to note that this rule matches too broadly in some instrumentation sources, and we're ignoring in certain ingestion paths until we add a configuration in rules that allows selecting the right ingest paths to apply it. Signed-off-by: Galo Navarro * Update definitions/ext-service/definition.yml Co-authored-by: Jonathan Gordon Co-authored-by: Cian Buckley Co-authored-by: Jonathan Gordon --- definitions/ext-service/definition.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/definitions/ext-service/definition.yml b/definitions/ext-service/definition.yml index 0afa0dc80..847f9ac97 100644 --- a/definitions/ext-service/definition.yml +++ b/definitions/ext-service/definition.yml @@ -107,6 +107,27 @@ synthesis: k8s.namespace.name: entityTagName: k8s.namespaceName + # IMPORTANT: + # This rule matches on any telemetry with service.name + # which is too broad for some telemetry sources, resulting + # in matches that are not actually about services. We're + # keeping it for backwards compatibility reasons but it + # is being ignored in some internal services while we add + # a configuration option to choose the relevant ingestion + # sources for each rule. + - identifier: service.name + name: service.name + encodeIdentifierInGUID: true + conditions: + - attribute: service.name + tags: + telemetry.sdk.name: + entityTagName: instrumentation.provider + telemetry.sdk.language: + entityTagName: language + telemetry.sdk.version: + + compositeMetrics: goldenMetrics: - golden_metrics.yml