From ebb4b908702389bc761b45ccc8bb3fd7acced8e3 Mon Sep 17 00:00:00 2001 From: pr0n00gler Date: Thu, 31 Oct 2024 15:40:46 +0200 Subject: [PATCH 1/2] fix nullables --- src/testcases/parallel/grpc_queries.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testcases/parallel/grpc_queries.test.ts b/src/testcases/parallel/grpc_queries.test.ts index 67ce4a64..f64878d9 100644 --- a/src/testcases/parallel/grpc_queries.test.ts +++ b/src/testcases/parallel/grpc_queries.test.ts @@ -226,7 +226,7 @@ describe('Neutron / Grpc Queries', () => { const res = await neutronClient.queryContractSmart(contractAddress, { tokenfactory_params: {}, }); - expect(res.params.denom_creation_gas_consume).toBe('0'); + expect(res.params.denom_creation_gas_consume).toBe(null); }); test('tokenfactory denom authority metadata should work', async () => { From 009629786a9ab57251e58c194ccddb4e9948b6ad Mon Sep 17 00:00:00 2001 From: pr0n00gler Date: Thu, 31 Oct 2024 19:23:32 +0200 Subject: [PATCH 2/2] fix tests --- src/testcases/run_in_band/dex_grpc.test.ts | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/testcases/run_in_band/dex_grpc.test.ts b/src/testcases/run_in_band/dex_grpc.test.ts index 15458d35..ea2729c4 100644 --- a/src/testcases/run_in_band/dex_grpc.test.ts +++ b/src/testcases/run_in_band/dex_grpc.test.ts @@ -138,7 +138,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '1220000000000000000000000000', amount_in: '1000000', order_type: LimitOrderType.GoodTilCanceled, - max_amount_out: '', }, }); expect(res.code).toEqual(0); @@ -170,7 +169,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '998000000000000000000000000', amount_in: '1000000', order_type: LimitOrderType.ImmediateOrCancel, - max_amount_out: '', }, }); expect(res.code).toEqual(0); @@ -186,7 +184,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '1220000000000000000000000000', amount_in: '1000000', order_type: LimitOrderType.JustInTime, - max_amount_out: '', }, }); expect(res.code).toEqual(0); @@ -204,7 +201,6 @@ describe('Neutron / dex module (grpc contract)', () => { Math.ceil(Date.now() / 1000) + 1000, ), order_type: LimitOrderType.GoodTilTime, - max_amount_out: '', }, }); expect(res.code).toEqual(0); @@ -221,7 +217,6 @@ describe('Neutron / dex module (grpc contract)', () => { amount_in: '10000000', expiration_time: secondsToRFC3339(1), order_type: LimitOrderType.GoodTilTime, - max_amount_out: '', }, }), ).rejects.toThrowError( @@ -240,7 +235,6 @@ describe('Neutron / dex module (grpc contract)', () => { amount_in: '10', expiration_time: secondsToRFC3339(1), order_type: 10, - max_amount_out: '', }, }), ).rejects.toThrowError( @@ -259,7 +253,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '818812575700000000000000000', amount_in: '1000000', order_type: LimitOrderType.GoodTilCanceled, - max_amount_out: '', }, }); expect(res1.code).toEqual(0); @@ -278,7 +271,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '1100000000000000000000000000', amount_in: '1000', order_type: LimitOrderType.ImmediateOrCancel, - max_amount_out: '', }, }); expect(res2.code).toEqual(0); @@ -453,7 +445,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '818812575700000000000000000', amount_in: '1000000', order_type: LimitOrderType.GoodTilCanceled, - max_amount_out: '', }, }); activeTrancheKey = getEventAttributesFromTx( @@ -472,7 +463,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '1000000000000000000000000000', amount_in: '1000', order_type: LimitOrderType.ImmediateOrCancel, - max_amount_out: '', }, }); @@ -486,7 +476,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '7381675653600000000000000000', amount_in: '1000000', order_type: LimitOrderType.JustInTime, - max_amount_out: '', }, }); inactiveTrancheKey = getEventAttributesFromTx( @@ -578,7 +567,7 @@ describe('Neutron / dex module (grpc contract)', () => { }, }, ); - expect(respNoPoolData.deposits[0].total_shares).toEqual(''); + expect(respNoPoolData.deposits[0].total_shares).toBeNull(); expect(respNoPoolData.deposits[0].pool).toBeNull(); }); test('AllTickLiquidity', async () => { @@ -739,8 +728,6 @@ describe('Neutron / dex module (grpc contract)', () => { limit_sell_price: '1200000000000000000000000000', amount_in: '10000', order_type: LimitOrderType.FillOrKill.toString(), - max_amount_out: '', - min_average_sell_price: '', }, }, });