Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with sklearn #12

Open
duboism opened this issue Jan 17, 2016 · 1 comment
Open

Compatibility with sklearn #12

duboism opened this issue Jan 17, 2016 · 1 comment

Comments

@duboism
Copy link

duboism commented Jan 17, 2016

Some properties of pylearn-parsimony Estimators are incompatible with sklearn Estimators. For instance in sklearn all parameters of the constructor have a default value (this allow to default construct the Estimator). There are many guidelines about the Estimator interface here (see chapters "APIs of scikit-learn objects" and "Rolling your own estimator"). Respecting this interface could help to mix parsimony and sklearn Estimators.

There are some tests in sklearn to ensure that all Estimators respect some assumptions of the API. One option to ensure the compatibility would be to use the same tests.

@tomlof
Copy link
Collaborator

tomlof commented Mar 6, 2017

Perhaps it's time to discuss this thoroughly? Being able to seamlessly cross over from scikit-learn to pylearn-parsimony and back would certainly be really useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants