Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Search Criteria Directory Behavior #44

Open
1 task done
JRandy77 opened this issue May 18, 2023 · 3 comments
Open
1 task done

[ENH] Search Criteria Directory Behavior #44

JRandy77 opened this issue May 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@JRandy77
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

New feature

When using search criteria for directory, won't look past the root directory if the root directory doesn't match search criteria.

[Search Criteria]
use search criteria = yes
regular expression for search criteria = sub-01
filter files = no
filter directories = yes

├───dataset1
│ ├───sub-01
│ │ ├───anat
│ │ ├───dwi
│ │ └───func
│ ├───sub-02
│ │ ├───anat
│ │ ├───dwi
│ │ └───func
│ ├───sub-03
│ │ ├───anat
│ │ └───dwi
│ └───sub-04
│ ├───anat
│ ├───dwi
│ └───wrong_dir_name
└───derivatives1
├───sub-01
│ ├───pipeline1
│ └───ses-pre
├───sub-02
│ ├───pipeline1
│ │ └───derivatives1
│ └───ses-pre
└───sub-03
├───pipeline1
└───ses-pre

image

Unclear documentation

No response

@JRandy77 JRandy77 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 18, 2023
@JRandy77
Copy link
Collaborator Author

This is the documented functionality, but I think it is incorrect.

@Remi-Gau
Copy link
Contributor

or least it could throw a warning or display a message explaining why it does that

@JRandy77
Copy link
Collaborator Author

I think that the options for searching should be increased. We are going to want to be able to specify directories we want to search through then continue to children as normal from there. i.e we only want to look in anat directories, but we also want to look at anat directory children. In addition to that, we might want to look at only that level of directory and no further.

There are a couple of priorities I can picture: filtering for the sake of specified output, and filtering to reduce amount of computation. Overall robustness vs. ease of use.

I don't think its worth continuing now, but we should discuss more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants