Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor public node index fetching into separate function #40

Open
alyssadai opened this issue Dec 4, 2023 · 1 comment
Open

Refactor public node index fetching into separate function #40

alyssadai opened this issue Dec 4, 2023 · 1 comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. refactor Simplifying or restructuring existing code or documentation.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 4, 2023

I think it would make sense to handle the "getting" of the remote node index in its own function, analogous to how we handle the local nodes in parse_nodes_as_dict - and have create_federation_node_index only be concerned with stitching them together.

The node-getter-functions should probably also raise their own warnings, both to make testing easier and to keep responsibilities a bit more separated.

@alyssadai alyssadai added refactor Simplifying or restructuring existing code or documentation. type:maintenance labels Dec 4, 2023
@alyssadai alyssadai added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Dec 4, 2023
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 18, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

No branches or pull requests

2 participants