Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn generate_neurobagel_example_jsonlds.sh into makefile #412

Open
alyssadai opened this issue Dec 19, 2024 · 0 comments
Open

Turn generate_neurobagel_example_jsonlds.sh into makefile #412

alyssadai opened this issue Dec 19, 2024 · 0 comments
Labels
refactor Simplifying or restructuring existing code or documentation. usability Issue affecting user or developer experience.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 19, 2024

The script operations may be better handled with a makefile. Mainly because you have to make sure that the script is being run only from the repo root dir (and a bunch of other stuff is also needed). But we're all human, so we might run it from the wrong dir, and then the docker commands are going to create a bunch of root-ownder folders in the repo - which is annoying.

makefile would make this all a lot easier. And it could also do the submodule getting / branching and so on for you. So I suggest we do that. If this is too big a move, let's split this off into its own PR

Also, we should simplify the internal mountpoint from /data/neurobagel/bagel-cli to /data.

Originally posted by @surchs in #410 (comment)

@alyssadai alyssadai added usability Issue affecting user or developer experience. refactor Simplifying or restructuring existing code or documentation. labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Simplifying or restructuring existing code or documentation. usability Issue affecting user or developer experience.
Projects
Status: No status
Development

No branches or pull requests

1 participant