You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The script operations may be better handled with a makefile. Mainly because you have to make sure that the script is being run only from the repo root dir (and a bunch of other stuff is also needed). But we're all human, so we might run it from the wrong dir, and then the docker commands are going to create a bunch of root-ownder folders in the repo - which is annoying.
makefile would make this all a lot easier. And it could also do the submodule getting / branching and so on for you. So I suggest we do that. If this is too big a move, let's split this off into its own PR
Also, we should simplify the internal mountpoint from /data/neurobagel/bagel-cli to /data.
The script operations may be better handled with a makefile. Mainly because you have to make sure that the script is being run only from the repo root dir (and a bunch of other stuff is also needed). But we're all human, so we might run it from the wrong dir, and then the docker commands are going to create a bunch of root-ownder folders in the repo - which is annoying.
makefile would make this all a lot easier. And it could also do the submodule getting / branching and so on for you. So I suggest we do that. If this is too big a move, let's split this off into its own PR
Also, we should simplify the internal mountpoint from
/data/neurobagel/bagel-cli
to/data
.Originally posted by @surchs in #410 (comment)
The text was updated successfully, but these errors were encountered: