Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define unique getters and mutations #247

Closed
Tracked by #231
surchs opened this issue Dec 7, 2022 · 3 comments
Closed
Tracked by #231

Define unique getters and mutations #247

surchs opened this issue Dec 7, 2022 · 3 comments
Assignees
@jarmoza
Labels
data store refactor Simplifying or restructuring existing code or documentation.

Comments

@surchs
Copy link
Contributor

surchs commented Dec 7, 2022 •
edited
Loading

Some components need a getter / mutation that is very specific and isn't used by anyone else (for now). We haven't defined these yet on the miro board. To prepare for #244, we should also add these unique getters / mutations to the board (and link them with their unique components).
This was referenced Dec 7, 2022
Closed
Closed
@surchs surchs added this to Neurobagel Dec 7, 2022
@surchs surchs moved this to Inbox in Neurobagel Dec 7, 2022
@surchs surchs added type:maintenance refactor Simplifying or restructuring existing code or documentation. labels Dec 7, 2022
@surchs surchs moved this from Inbox to Backlog in Neurobagel Dec 7, 2022
@surchs surchs moved this from Backlog to Ready in Neurobagel Dec 7, 2022
@surchs
Copy link
Contributor Author

surchs commented Dec 13, 2022

I think this is also done on the miro board. @rmanaem, could you check, and if you agree close?

@jarmoza
Copy link
Contributor

jarmoza commented Dec 13, 2022 •
edited
Loading

This is not done as of yet. I'm going to grab this and will mark when it's finished.

@jarmoza jarmoza self-assigned this Dec 13, 2022
@jarmoza jarmoza moved this from Ready to Doing in Neurobagel Dec 13, 2022
@surchs surchs moved this from Doing to Review in Neurobagel Dec 14, 2022
@surchs
Copy link
Contributor Author

surchs commented Dec 14, 2022

could you look at this and #245 and see if we can close this? I think you added all the ones we know of in #251

@surchs surchs closed this as completed Dec 15, 2022
Repository owner moved this from Review to Done in Neurobagel Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarmoza jarmoza

Labels
data store refactor Simplifying or restructuring existing code or documentation.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surchs @jarmoza