Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit or fill in data dictionary #185

Open
surchs opened this issue Aug 31, 2022 · 12 comments
Open

Allow users to edit or fill in data dictionary #185

surchs opened this issue Aug 31, 2022 · 12 comments
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.

Comments

@surchs
Copy link
Contributor

surchs commented Aug 31, 2022

As a user, while I am annotating data, I want to be able to fill in or edit the "Description" section of columns and values, so that I can create or update a data dictionary for this dataset while I am creating the annotations.

Example: I have a dataset that only has a participants.tsv file and no data dictionary. Thus, on the categorization page the description section for each column is empty. I now want to add a description for some of the columns. To do that I click into the (currently empty) description field for the column and start typing text. My expectation is that:

  • I can type in the description section of the columns, even if this section is empty
  • the text I have entered is stored without any further action (i.e. what is currently visible is what is also stored in the system)
  • there is an option to download the data dictionary as it is currently stored in the system, and this process will export my manual edits to me.
@surchs surchs moved this from Inbox to Backlog in Neurobagel Aug 31, 2022
@jarmoza
Copy link
Contributor

jarmoza commented Sep 7, 2022

Since there is a view of the data dictionary when it is loaded on the index page, there may be an expectation that the data dictionary is also editable there. The same would go for the participants.tsv. We should consider consistency in the UI. It may make the most sense to have this done on the index page and change the view of the data dictionary to an editable table – and gray out the participants tsv (also displayed in table form). There should be a max row view as well, of course, so that both data table and dictionary remain visible at all times.

@surchs surchs added feature:enhancement flag:discuss Flag issue that needs to be discussed before it can be implemented. and removed enhancement labels Nov 28, 2022
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 30, 2022
@surchs surchs removed the status in Neurobagel Jan 3, 2023
@jarmoza jarmoza removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jan 5, 2023
@jarmoza
Copy link
Contributor

jarmoza commented Jan 5, 2023

@surchs How do you feel about this feature? It could be a relatively simple change now that we are moving to the tool's output being an annotated data dictionary.

@surchs
Copy link
Contributor Author

surchs commented Jan 5, 2023

Yeah, I think it will be much easier to implement. We could flesh out the idea a little more and then add it to the next milestone. wdyt?

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 5, 2023
@jarmoza
Copy link
Contributor

jarmoza commented Feb 7, 2023

@surchs Likewise, do you have any further thoughts on this feature/when to implement? Coincidentally, we technically have the ability to do this now by reverting the textarea for the data dictionary on the landing page back to using a v-model attribute. Definitely not as slick as the suggested above UI, but users can hand edit the data dictionary in the text box and it the edits should be reflected in the current ...userProvided data dictionary.

@surchs
Copy link
Contributor Author

surchs commented Feb 7, 2023

do you have any further thoughts on this feature/when to implement?

I think we can sneak it into one of the next releases where we have some extra capacity with mid-low priority. At the moment, nothing critical depends on this (this may change)

users can hand edit the data dictionary in the text box and it the edits should be reflected

I see. That's an interesting solution, but I would vote for doing this cleanly with a nice user experience / UI directly.

@jarmoza
Copy link
Contributor

jarmoza commented Feb 7, 2023

I see. That's an interesting solution, but I would vote for doing this cleanly with a nice user experience / UI directly.

Fully agreed. Just a funny coincidence.

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 8, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 23, 2023
@Manya-tech
Copy link
Contributor

Manya-tech commented Mar 17, 2024

Hello

I am Manya Gupta. I was using the annotation tool as a potential GSoC contributor and struggled with this problem. Then I read the documentation and there was no mention of how to add description or that this feature is not available yet. Looking at the images provided in the guide made me think that maybe I missed the part mentioning how to add descriptions leading me to read it a few more times. I would like to suggest updating the documentation to enhance the user experience by mentioning that this feature will be added in the next release.

Hope this suggestion was helpful!

@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 19, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Mar 19, 2024

Hi @Manya-tech
Thanks for the feedback! Would you like to open an issue for us to keep track of?

Copy link

github-actions bot commented Jun 3, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jun 3, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.
Projects
Status: No status
Development

No branches or pull requests

4 participants