From 621369050968f970dcba3c3fa43d2609e5391337 Mon Sep 17 00:00:00 2001 From: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com> Date: Thu, 12 Dec 2024 16:20:15 -0500 Subject: [PATCH 1/2] [MNT] Removed `FromInt` age transformation (#829) * Removed `FromInt` transformation * Updated relevant component test * Addressed PR comment --- .../good/ds003653_participant_annotated_1698934398962.json | 4 ++-- cypress/unit/store-getter-getContinousJsonOutput.cy.js | 5 ----- cypress/unit/store-getter-getTransformOptions.cy.js | 7 +------ store/index.js | 6 ------ 4 files changed, 3 insertions(+), 19 deletions(-) diff --git a/cypress/fixtures/examples/good/ds003653_participant_annotated_1698934398962.json b/cypress/fixtures/examples/good/ds003653_participant_annotated_1698934398962.json index df085cbd..cb9c98aa 100644 --- a/cypress/fixtures/examples/good/ds003653_participant_annotated_1698934398962.json +++ b/cypress/fixtures/examples/good/ds003653_participant_annotated_1698934398962.json @@ -16,8 +16,8 @@ "TermURL": "nb:Age" }, "Transformation": { - "Label": "integer value", - "TermURL": "nb:FromInt" + "Label": "float value", + "TermURL": "nb:FromFloat" }, "MissingValues": [] }, diff --git a/cypress/unit/store-getter-getContinousJsonOutput.cy.js b/cypress/unit/store-getter-getContinousJsonOutput.cy.js index 6579a596..1eed7b71 100644 --- a/cypress/unit/store-getter-getContinousJsonOutput.cy.js +++ b/cypress/unit/store-getter-getContinousJsonOutput.cy.js @@ -44,11 +44,6 @@ let store = { Label: "float value", TermURL: "nb:FromFloat" }, - int: { - - Label: "integer value", - TermURL: "nb:FromInt" - }, iso8601: { Label: "period of time defined according to the ISO8601 standard", diff --git a/cypress/unit/store-getter-getTransformOptions.cy.js b/cypress/unit/store-getter-getTransformOptions.cy.js index 47afca9a..90ee7488 100644 --- a/cypress/unit/store-getter-getTransformOptions.cy.js +++ b/cypress/unit/store-getter-getTransformOptions.cy.js @@ -30,11 +30,6 @@ let store = { Label: "float value" }, - int: { - TermURL: "nb:FromInt", - Label: "integer value" - }, - iso8601: { TermURL: "nb:FromISO8601", Label: "period of time defined according to the ISO8601 standard" @@ -52,7 +47,7 @@ describe("getTransformOptions", () => { // Assert expect(options).to.deep.equal([ - "bounded", "euro", "float", "int", "iso8601" + "bounded", "euro", "float", "iso8601" ]); }); }); \ No newline at end of file diff --git a/store/index.js b/store/index.js index b0e6b732..b682d4c9 100644 --- a/store/index.js +++ b/store/index.js @@ -137,12 +137,6 @@ export const state = () => ({ TermURL: "nb:FromFloat" }, - int: { - - Label: "integer value", - TermURL: "nb:FromInt" - }, - iso8601: { Label: "period of time defined according to the ISO8601 standard", From fe3f035bba21bbb8b5e423a3ba3354281cce9c44 Mon Sep 17 00:00:00 2001 From: Arman Jahanpour <77515879+rmanaem@users.noreply.github.com> Date: Thu, 12 Dec 2024 16:33:29 -0500 Subject: [PATCH 2/2] [ENH] Made requirement of age annotation more prominent (#830) * Removed `FromInt` transformation * Updated relevant component test * Made requirement of age annotation more prominent * Addressed PR comment * Addressed PR comment --- pages/download.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/download.vue b/pages/download.vue index e3a84cac..7bd3d667 100644 --- a/pages/download.vue +++ b/pages/download.vue @@ -9,7 +9,7 @@ There are incomplete annotations for columns that were mapped to variables. You can go back and complete these annotations before you download the .json data dictionary.

- The following columns are missing annotations: + The following columns have incomplete annotations: