Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller classes shouldn't inherit from each other #70

Open
danielbear opened this issue Apr 21, 2022 · 0 comments
Open

Controller classes shouldn't inherit from each other #70

danielbear opened this issue Apr 21, 2022 · 0 comments
Assignees

Comments

@danielbear
Copy link

For instance, man of the classes inherit from MultiDominoes (which has the basic functionality for placing the target, zone, etc.)

Create a separate base class for "OCP" and then have each of the Physion controller classes inherit from that, for the sake of clarity. This will also prevent overloading of arguments, which may do different things for different scenarios.

@danielbear danielbear self-assigned this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant