Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code for morphology is suboptimal and should be rewritten #16

Closed
vovaf709 opened this issue Jan 16, 2023 · 2 comments
Closed

Code for morphology is suboptimal and should be rewritten #16

vovaf709 opened this issue Jan 16, 2023 · 2 comments
Assignees
@LeoQay
Labels
bug Something isn't working

Comments

@vovaf709
Copy link
Collaborator

Morphology functions are faster than their counterparts only because of parallel execution. Working single-threadedly they suck. Very likely there is some bug that should be fixed
@vovaf709 vovaf709 added the bug Something isn't working label Jan 16, 2023
@vovaf709
Copy link
Collaborator Author

Current implementation has following drawbacks:

  • layout checks are unnecessary
  • border checks in get_pixel3d are unnecessary for footprint
  • border checks in get_pixel3d are unnecessary for inner pixels of input tensor

It is reasonable to figure out how last 2 problems are adressed in the original scipy code

@vovaf709 vovaf709 mentioned this issue Aug 9, 2023
Merged
@vovaf709
Copy link
Collaborator Author

closed by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeoQay LeoQay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vovaf709 @LeoQay