Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Migrations and Backward Compatibility Issues #345

Open
lyuyangh opened this issue Sep 20, 2022 · 7 comments
Open

DB Migrations and Backward Compatibility Issues #345

lyuyangh opened this issue Sep 20, 2022 · 7 comments

Comments

@lyuyangh
Copy link
Member

This thread keeps track of everything related to DB migrations and backward compatibility issues.

@lyuyangh
Copy link
Member Author

lyuyangh commented Sep 20, 2022

PR #335

  • System outputs are now stored in Cloud Storage instead of MongoDB
  • The PR is backward compatible so no DB migration is required.
  • (removed in remove outdated code #422 ) code & code were added for backward compatibility reasons. They can be removed when we regenerate all system analyses next time.

@lyuyangh lyuyangh changed the title DB Migrations and Backward Compatibilities DB Migrations and Backward Compatibility Issues Sep 20, 2022
@lyuyangh
Copy link
Member Author

PR #365

  • DB migration was performed because I couldn't make the code backward compatible when I upgraded the SDK to v0.11.2.

@lyuyangh
Copy link
Member Author

PR #434 #435 #436

  • Migration was performed for all three PRs in one go. Please refer to the PRs to see what was changed.

@OscarWang114
Copy link
Collaborator

PR #366

  • DB migration was performed to create a user metadata collection and to replace all system's creator fields from emails to user ids.

@lyuyangh
Copy link
Member Author

lyuyangh commented Oct 24, 2022

PR #439 #459

  • Migration was performed for dev.
  • Prod DB migration was performed on Oct 31, 2022.

@lyuyangh
Copy link
Member Author

lyuyangh commented Nov 4, 2022

PR #490 #492

  • Migration for both dev and prod performed on Nov 4, 2022.

@lyuyangh
Copy link
Member Author

lyuyangh commented Nov 8, 2022

PR #493 (#494 also related)

  • Migration for both dev and prod performed on Nov 8, 2022.
  • sdk_version_used is set to "old" for all systems so all previous systems will get re-analyzed when a user clicks "Analysis".
  • This migration also partially addresses an issue with custom analyses. custom_features and custom_analyses come from two sources: the dataset (if it is a datalab dataset) or the output file (provided by the user). Because of how the SDK is implemented, the latter always overrides the former if it is present. This migration brings back all custom_analyses of datasets even if a user-defined custom_analyses is present. The code still doesn't work though so new systems still suffer from this issue. When the code is fixed, I can run the migration again to fix all the exiting systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants