Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate system file simplified API #32

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Evaluate system file simplified API #32

merged 4 commits into from
Oct 11, 2022

Conversation

neubig
Copy link
Collaborator

@neubig neubig commented Oct 10, 2022

Starts to address #31

This simplifies the API to evaluate systems to be a single API call such as the following:

result: dict = client.evaluate_system_file(
    system_output_file="sst2-output.txt",
    system_output_file_type="text",
    task="text-classification",
    system_name="test_cli",
    metric_names=["Accuracy"],
    source_language="en",
    target_language="en",
    dataset="sst2",
    split="test",
    shared_users=["[email protected]"],
)

@neubig neubig mentioned this pull request Oct 10, 2022
@@ -53,13 +34,13 @@ def main():
help="Name of the system that you are evaluating",
)
parser.add_argument(
"--system_output",
"--system_output_file",
Copy link
Collaborator

@pfliu-nlp pfliu-nlp Oct 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes in this PR will not break the implementation of the one in the teaching class. (but let me know if it will affect so that I can make corresponding revisions)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will, but I'd actually suggest that you set a specific version that you use for the class to prevent any future changes from causing issues. That's what I did as well: https://github.com/neubig/minbert-assignment/blob/main/setup.sh#L13

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"suggest that you set a specific version that you use for the class to prevent any future changes from causing issues"

yeah, this makes sense

@neubig neubig merged commit 6ac0f2f into main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants