Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader could have streaming option #438

Open
neubig opened this issue Sep 2, 2022 · 0 comments
Open

Loader could have streaming option #438

neubig opened this issue Sep 2, 2022 · 0 comments

Comments

@neubig
Copy link
Contributor

neubig commented Sep 2, 2022

Currently Loader only loads the entire dataset into memory all at once. This might not be ideal for very large datasets.

It wouldn't be too hard to add a streaming option by modifying these lines to zip and yield:

data_list: list[dict] = output_loaded_data.samples
for i, output in enumerate(data_list):
dataset_loaded_data[i].update(output)
return dataset_loaded_data

But this would also require checking throughout the codebase that the downstream usage of this function is not assuming a list, but an iterable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant