Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non id non attribute fields are not available during creation #259

Open
retnuh opened this issue Jan 19, 2024 · 1 comment
Open

non id non attribute fields are not available during creation #259

retnuh opened this issue Jan 19, 2024 · 1 comment
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement

Comments

@retnuh
Copy link

retnuh commented Jan 19, 2024

Environment

  • DiffSync version: latest - 1.10.0

Observed Behaviour

Diffsync doesn't pass along fields that are not ids or attributes during creation.

Expected Behaviour

There should be a mechanism to access those types of fields during create.
An example use case would be creating a new object with a default name from source A, but in general source A doesn't know or care about the name and it's not usually part of the diffsync.

@Kircheneer Kircheneer added status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement labels Jan 22, 2024
@Yoyasp
Copy link

Yoyasp commented Feb 1, 2024

I would also like to have this implemented.
Lots of datasets i use proved a Primary key that is only locally significant, but is required to make a patch request.

I see in the example that they added a database_pk which is optional, but they never use the value it is assigned.

The only way to lookup this value is in the DiffSync class in the datastore: self.store._data['modelname']['id'].database_pk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants