Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issue for the light-codegen for master branch (JDK11) #466

Open
GavinChenYan opened this issue Oct 4, 2020 · 0 comments
Open

The issue for the light-codegen for master branch (JDK11) #466

GavinChenYan opened this issue Oct 4, 2020 · 0 comments

Comments

@GavinChenYan
Copy link
Contributor

If user use the supportDB config value in the config.json

"supportDb": true,

The light-codegen will generate datasource config in the service.yml:

'''

  • javax.sql.DataSource:
    • com.zaxxer.hikari.HikariDataSource:
      DriverClassName:
      jdbcUrl:
      username:
      password:
      maximumPoolSize: 10
      useServerPrepStmts: true
      cachePrepStmts: true
      cacheCallableStmts: true
      prepStmtCacheSize: 10
      prepStmtCacheSqlLimit: 2048
      connectionTimeout: 2000

'''

And in the values.yml, light-codegen output:

service.singletons:

I think user may chose different ways for datasource, if user use light--4j data-source module,then it will use datasource.yml file and user can flexibly choose the way for database process.

So I would like suggest to remove the datasource in the setting in the service yam and change it to:

singletons: ${service.singletons:}

And user can only deal with on config file: values.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant