Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several issues that need to be discussed to find better solutions #307

Open
stevehu opened this issue May 21, 2019 · 2 comments
Open

several issues that need to be discussed to find better solutions #307

stevehu opened this issue May 21, 2019 · 2 comments

Comments

@stevehu
Copy link
Contributor

stevehu commented May 21, 2019

  1. We cannot ask users to add this exclude for the parameterizer in the config.json. In my opinion, we might need to put the parameters into the template instead of processing the config files.

  2. We need to find a way to move the values.yml into the config folder in the generated project. However, we cannot do that as the service.yml need to set the value for the service.singletons.

  3. Is there a way to set the default value for singletons in the service.yml file. If yes, we need to do that.

  4. We need to think about the existing users with existing config.json when we change the light-codegen. That means we should always have a default value for the new flags we add to the config.json

  5. Make the values.yml generation as default to encourage users to use it. It can be optionally turned off from config.json?

  6. More to add during the discussion.

@ddobrin
Copy link
Contributor

ddobrin commented May 21, 2019

There are now 40+ APIs at my current client, with several releases going on. We need to be careful with codegen changes, as the team has parameterized files and are excluding some files from parameterization.

One of the little things done is setting up the values.yml in a //values folder, and starting the APIs for testing always with the command-line: java -Dlight-4j-config-dir=values -jar xyz.jar

Ex.:
"generateEnvVars": {
"generate": true,
"skipArray": true,
"skipMap": true,
"exclude": [
"handler.yml",
"values.yml",
"client.yml",
"datasource.yml",
"service.yml"
]
},
"generateValuesYml": true

@ddobrin
Copy link
Contributor

ddobrin commented May 21, 2019

I highly recommend, as in the past, that we create *.raw files for the files we wish to have generated, rather than copying them from the handlerconfig 1:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants