Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis server example #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

trustin
Copy link

@trustin trustin commented Apr 17, 2023

Motivation:

  • We have a Redis client example, but not its server counterpart.
  • This repository is not very usable at its current form because it depends on Netty 5.0.0.Final-SNAPSHOT which is actually very outdated.

Modifications:

  • Revert the repository to use Netty 4.1.
  • Add RedisServer and RedisServerHandler which demonstrate how to write a server that understands RESP.
    • Currently supports GET, SET, DEL and SHUTDOWN command in a very simplistic form.

Result:

  • This repository now builds without failure.
  • This repository now uses the Netty version that's actually up to date.
  • We now have a Redis server example, as well as a client-side one.

Motivation:

- We have a Redis client example, but not its server counterpart.
- This repository is not very usable at its current form because it
  depends on Netty 5.0.0.Final-SNAPSHOT which is actually very outdated.

Modifications:

- Revert the repository to use Netty 4.1.
- Add `RedisServer` and `RedisServerHandler` which demonstrate how to
  write a server that understands RESP.
  - Currently supports GET, SET, DEL and SHUTDOWN command in a very
    simplistic form.

Result:

- This repository now builds without failure.
- This repository now uses the Netty version that's actually up to date.
- We now have a Redis server example, as well as a client-side one.
@trustin trustin requested a review from chrisvest April 17, 2023 14:45
@chrisvest
Copy link
Contributor

For Netty 4.1, we have the redis code in our main netty/netty repository. This contrib repo is here so we could remove that module from the Netty 5 main branch.

@trustin
Copy link
Author

trustin commented Apr 18, 2023

@chrisvest Then shall I send a PR to netty/netty#4.1 then?

@chrisvest
Copy link
Contributor

@trustin For adding an example server based on 4.1, I think that's the correct place.

@sh-cho
Copy link

sh-cho commented Aug 5, 2023

@trustin I'd like to continue this on netty/netty, if you don't mind.
Although redis codec will be removed main repo, example of redis server implementation will work well until someday netty5 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants