Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build script issue - package.json gets copied into the dist/ folder #8

Open
maranomynet opened this issue Jan 14, 2021 · 2 comments
Open

Comments

@maranomynet
Copy link
Collaborator

maranomynet commented Jan 14, 2021

...which in turn causes an off-by-one error in the version reported by the generated types:

From the top of a file created by the latest version v1.6.2:

/**
 Schema Generated with mysql-schema-ts 1.6.1
*/
@maranomynet maranomynet changed the title build script issue - old package.json inside dist folder build script issue - package.json gets copied into the dist/ folder Jan 14, 2021
@maranomynet
Copy link
Collaborator Author

"pub": "tsc && np",

I'm guessing this line could simply change into something like:

 "pub": "tsc && rm dist/package.json* && np"

no?

@nettofarah
Copy link
Owner

I'm unsure tbh, as this sounds like a chicken and egg sort of problem 😬
I might change the way we publish packages to use something a bit simpler, or remove the version header altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants