From eade6ac4b5934577031af4b71e4878d560da6e5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eduardo=20Bou=C3=A7as?= Date: Mon, 20 Nov 2023 10:33:41 +0000 Subject: [PATCH 1/3] chore: add TypeScript conversion progress tracker --- .github/workflows/benchmark.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 2920016057e..675020f6ae4 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -25,6 +25,10 @@ jobs: run: npm ls -a -p | wc -l | tr -d ' \n' > .delta.dependencyCount && echo " (Dependency count)" >> .delta.dependencyCount + - name: Get TypeScript conversion progress + run: + grep -r --exclude-dir="node_modules" --include="*.mts" "@ts-expect-error" . | wc -l | xargs > + .delta.tsConversion && echo " (TypeScript conversion progress)" >> .delta.tsConversion - name: Save PR number if: github.event_name == 'pull_request' run: echo ${{ github.event.number }} > ./pr_number From 20bbb1baaf9d6cc84befa709116ff17107f4dea5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eduardo=20Bou=C3=A7as?= Date: Mon, 20 Nov 2023 10:40:21 +0000 Subject: [PATCH 2/3] chore: update metric name --- .github/workflows/benchmark.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 675020f6ae4..9c2fa632663 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -28,7 +28,7 @@ jobs: - name: Get TypeScript conversion progress run: grep -r --exclude-dir="node_modules" --include="*.mts" "@ts-expect-error" . | wc -l | xargs > - .delta.tsConversion && echo " (TypeScript conversion progress)" >> .delta.tsConversion + .delta.tsConversion && echo " (Number of `@ts-expect-error` directives)" >> .delta.tsConversion - name: Save PR number if: github.event_name == 'pull_request' run: echo ${{ github.event.number }} > ./pr_number From d2c9ea2b5ce3ece54e5f4105f962f4972295894b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eduardo=20Bou=C3=A7as?= Date: Mon, 20 Nov 2023 10:42:47 +0000 Subject: [PATCH 3/3] chore: update metric name (again) --- .github/workflows/benchmark.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 9c2fa632663..3aa1984f042 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -28,7 +28,7 @@ jobs: - name: Get TypeScript conversion progress run: grep -r --exclude-dir="node_modules" --include="*.mts" "@ts-expect-error" . | wc -l | xargs > - .delta.tsConversion && echo " (Number of `@ts-expect-error` directives)" >> .delta.tsConversion + .delta.tsConversion && echo " (Number of ts-expect-error directives)" >> .delta.tsConversion - name: Save PR number if: github.event_name == 'pull_request' run: echo ${{ github.event.number }} > ./pr_number