feat(@netlify/build-info): add React Router 7 detection #5930
+192
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
from
bfe95a3 to
d6c7af4
Compare
mrstork
reviewed
Dec 10, 2024
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
from
d6c7af4 to
820bd41
Compare
Technically we'd want to add it to Vite's `excludedNpmDependencies`, but we actually only want to exclude RR >=7. Many RR <7 users will be using Vite, so we don't want to break that. But everything works fine if we just don't do anything here, since frameworks get priority over bundlers when there are multiple matches. (I'm not really sure why we both excluding Vite frameworks in the Vite logic).
serhalp
force-pushed
the
serhalp/frb-1511-support-react-router-7
branch
from
820bd41 to
a75b85a
Compare
mrstork
reviewed
Dec 11, 2024
| readonly id = 'react-router' | ||
| name = 'React Router' | ||
| configFiles = ['react-router.config.ts', 'react-router.config.js'] | ||
| npmDependencies = ['react-router'] |
There was a problem hiding this comment.
Do we want to detect the plugin we built as well?
There was a problem hiding this comment.
Good question. We've been doing that for some of the frameworks, but I was thinking about it and couldn't come up with any reason for it, so I didn't include it. You definitely need react-router to use react-router; checking for additional dependencies won't help.
mrstork
previously approved these changes
Dec 11, 2024
mrstork
approved these changes
Dec 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
React Router 7 was released a couple weeks ago. It's sort of the next version of Remix and also sort of the next version of React Router. It can be used as a library or as a framework.
Thus, this adds it to our framework detection, but only for version 7+.
There are some oddities here:
@react-router/devas an almost certain hint that the site uses RR7 as a framework, but according to the Remix/RR team this may not hold forever. Seems OK for now.excludedNpmDependencies, but we actually only want to exclude RR >=7 (many RR <7 users will be using Vite or something else, so we don't want to break that).